Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 7251004: Deciding best connection to schedule requests on based on cwnd and idle time (Reopened after revert) (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Syncing to head Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_network_transaction_unittest.cc
===================================================================
--- net/http/http_network_transaction_unittest.cc (revision 90551)
+++ net/http/http_network_transaction_unittest.cc (working copy)
@@ -12,6 +12,7 @@
#include "base/file_path.h"
#include "base/file_util.h"
#include "base/memory/scoped_ptr.h"
+#include "base/metrics/histogram.h"
#include "base/utf_string_conversions.h"
#include "net/base/auth.h"
#include "net/base/capturing_net_log.h"
@@ -333,6 +334,34 @@
static const char kAlternateProtocolHttpHeader[] =
"Alternate-Protocol: 443:npn-spdy/2\r\n\r\n";
+TEST_F(HttpNetworkTransactionTest, LogNumRttVsBytesMetrics_WarmestSocket) {
+ MockRead data_reads[1000];
+ data_reads[0] = MockRead("HTTP/1.0 200 OK\r\n\r\n");
+ for (int i = 1; i < 999; i++) {
+ data_reads[i] = MockRead("Gagan is a good boy!");
+ }
+ data_reads[999] = MockRead(false, OK);
+
+ net::SetSocketReusePolicy(0);
+ SimpleGetHelperResult out = SimpleGetHelper(data_reads,
+ arraysize(data_reads));
+
+ base::Histogram* histogram = NULL;
+ base::StatisticsRecorder::FindHistogram(
+ "Net.Num_RTT_vs_KB_warmest_socket_15KB", &histogram);
+ CHECK(histogram);
+
+ base::Histogram::SampleSet sample_set;
+ histogram->SnapshotSample(&sample_set);
+ EXPECT_EQ(1, sample_set.TotalCount());
+
+ EXPECT_EQ(OK, out.rv);
+ EXPECT_EQ("HTTP/1.0 200 OK", out.status_line);
+}
+
+// TODO(gagansingh): Add test for LogNumRttVsBytesMetrics_LastAccessSocket once
+// it is possible to clear histograms from previous tests.
+
TEST_F(HttpNetworkTransactionTest, Basic) {
SessionDependencies session_deps;
scoped_ptr<HttpTransaction> trans(

Powered by Google App Engine
This is Rietveld 408576698