Issue 725073003: Add UseCounters for UIEvent.charCode/keyCode/which

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 725073003: Add UseCounters for UIEvent.charCode/keyCode/which (Closed)

Created:
6 years, 1 month ago by philipj_slow

Modified:
6 years, 1 month ago

Reviewers:
Rick Byers

CC:
blink-reviews, arv+blink, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Add UseCounters for UIEvent.charCode/keyCode/which These belong on the KeyboardEvent interface, so add them to KeyboardEvent.idl and count anything that still falls back to UIEvent. MouseEvent.which does not appear to be in any spec, but it is supported by most browsers. Measure its usage to help determine its future. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185393

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -4 lines)			Patch
M	Source/core/events/KeyboardEvent.idl	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	Source/core/events/MouseEvent.idl	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/events/UIEvent.idl	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/frame/UseCounter.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/725073003/1

6 years, 1 month ago (2014-11-14 22:07:08 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-14 22:09:18 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 185393

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages