Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 724953002: Use Blink-style method casing for EndOfScopeTask::run() (Closed)

Created:
6 years, 1 month ago by jsbell
Modified:
6 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, jsbell+idb_chromium.org, arv+blink, cmumford, dgrogan
Project:
blink
Visibility:
Public.

Description

Use Blink-style method casing for EndOfScopeTask::run() I guess we're all so used to looking at Chromium's base::Callback::Run() that no-one noticed. Oops! R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185330

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/bindings/core/v8/V8PerIsolateData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8PerIsolateData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBTransaction.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
jsbell
haraken@ - R? CQ?
6 years, 1 month ago (2014-11-13 21:26:52 UTC) #1
haraken
LGTM
6 years, 1 month ago (2014-11-13 23:25:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/724953002/1
6 years, 1 month ago (2014-11-13 23:25:28 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 23:32:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185330

Powered by Google App Engine
This is Rietveld 408576698