Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 724933002: Add support for shared library resources to java_apk build rules for real. (Closed)

Created:
6 years, 1 month ago by mkosiba (inactive)
Modified:
6 years, 1 month ago
Reviewers:
cjhopman
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add support for shared library resources to java_apk build rules for real. In https://crrev.com/f90b7151cb809d8ec9ab31f7be9e9f8f575fd4d0 I added support for the process_resources rule but support in package_resources is needed to generate a compatible .apk file. BUG=430997 Committed: https://crrev.com/e5c9c76ba67333b430debcaaa5d4880e801114d5 Cr-Commit-Position: refs/heads/master@{#304097}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M build/android/gyp/package_resources.py View 2 chunks +7 lines, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 2 chunks +5 lines, -0 lines 0 comments Download
M build/java_apk.gypi View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/android_webview_glue/android_webview_glue.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/android_webview_glue/android_webview_glue_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
mkosiba (inactive)
PTAL
6 years, 1 month ago (2014-11-13 20:49:01 UTC) #2
cjhopman
Does package_resources still need the flag? The files generated at that step are only used ...
6 years, 1 month ago (2014-11-13 21:11:48 UTC) #3
cjhopman
On 2014/11/13 21:11:48, cjhopman wrote: > Does package_resources still need the flag? The files generated ...
6 years, 1 month ago (2014-11-13 21:12:35 UTC) #4
mkosiba (inactive)
On 2014/11/13 21:11:48, cjhopman wrote: > Does package_resources still need the flag? The files generated ...
6 years, 1 month ago (2014-11-13 21:13:06 UTC) #5
mkosiba (inactive)
On 2014/11/13 21:13:06, mkosiba wrote: > On 2014/11/13 21:11:48, cjhopman wrote: > > Does package_resources ...
6 years, 1 month ago (2014-11-13 21:15:20 UTC) #6
cjhopman
lgtm
6 years, 1 month ago (2014-11-13 21:18:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/724933002/1
6 years, 1 month ago (2014-11-13 21:22:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-13 22:38:05 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 22:38:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5c9c76ba67333b430debcaaa5d4880e801114d5
Cr-Commit-Position: refs/heads/master@{#304097}

Powered by Google App Engine
This is Rietveld 408576698