Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 724863003: Fix http/tests/images/drag-image-to-desktop.html (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
Reviewers:
Nate Chapin
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Fix http/tests/images/drag-image-to-desktop.html PHP 5.4.0 and newer implement hex2bin natively. Since PHP versions aren't uniform across platforms, just prefix it and hope it doesn't collide with another function in the future. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185322

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M LayoutTests/TestExpectations View 3 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/misc/resources/generatedimage.php View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
dcheng
Yay! PHP!
6 years, 1 month ago (2014-11-13 20:11:56 UTC) #2
Nate Chapin
lgtm
6 years, 1 month ago (2014-11-13 20:25:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/724863003/1
6 years, 1 month ago (2014-11-13 20:49:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 185322
6 years, 1 month ago (2014-11-13 21:23:12 UTC) #6
Peter Beverloo
On 2014/11/13 21:23:12, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) as ...
6 years, 1 month ago (2014-11-14 11:29:47 UTC) #7
dcheng
6 years, 1 month ago (2014-11-14 19:18:18 UTC) #8
Message was sent while issue was closed.
On 2014/11/14 at 11:29:47, peter wrote:
> On 2014/11/13 21:23:12, I haz the power (commit-bot) wrote:
> > Committed patchset #1 (id:1) as 185322
> 
> "@ECHO OFF :BEGIN CLS ECHO Creating directory "c:\booom"... cmd /c mkdir
c:\booom ECHO Ready PAUSE :END"
> 
> Is that stuff there on purpose?

Originally, the test referred to generatedimage.bat, and the idea was that we
would save it with the right extension. I guess there were attacks where you
could trick Blink into saving a picture with a .bat file extension. If the user
inadvertently ran the .bat file later, then bad things. I don't know that those
lines are strictly necessary, but it doesn't hurt to have them either, right?

Powered by Google App Engine
This is Rietveld 408576698