Issue 724813002: Revert of Fix build for iOS after "Make nanobench and dm be usable from Chromium build"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 724813002: Revert of Fix build for iOS after "Make nanobench and dm be usable from Chromium build" (Closed)

Created:
6 years, 1 month ago by jcgregorio

Modified:
6 years, 1 month ago

Reviewers:
Kimmo Kinnunen, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Fix build for iOS after "Make nanobench and dm be usable from Chromium build" (patchset #1 id:1 of https://codereview.chromium.org/716413003/) Reason for revert: Causes breakages on Mac. Original issue's description: > Fix build for iOS after "Make nanobench and dm be usable from Chromium build" > > Fix build for iOS after "Make nanobench and dm be usable from Chromium > build" > > BUG=skia:2992 > > Committed: https://skia.googlesource.com/skia/+/0935aed2787eb79629125bdfef9aba2a6a283ef7 TBR=robertphillips@google.com,kkinnunen@nvidia.com NOTREECHECKS=true NOTRY=true BUG=skia:2992 Committed: https://skia.googlesource.com/skia/+/1c6e7571d40e31247609fd7469f8422018304310

Created: 6 years, 1 month ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	gyp/iOSShell.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

jcgregorio

Created Revert of Fix build for iOS after "Make nanobench and dm be usable from ...

6 years, 1 month ago (2014-11-13 15:56:16 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/724813002/1

6 years, 1 month ago (2014-11-13 15:57:52 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-11-13 15:58:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1c6e7571d40e31247609fd7469f8422018304310