Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: content/worker/worker_devtools_agent.h

Issue 7248076: DevTools: add initial support for shared workers debugging (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments addressed Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/worker/worker_devtools_agent.h
diff --git a/content/worker/worker_devtools_agent.h b/content/worker/worker_devtools_agent.h
index 64dc3c80595091fac9ae526b374051d1b47fff3d..372dac7a1fdae553b90b305bc5c6f06adf1b616f 100644
--- a/content/worker/worker_devtools_agent.h
+++ b/content/worker/worker_devtools_agent.h
@@ -15,28 +15,30 @@ class Message;
}
namespace WebKit {
+class WebSharedWorker;
class WebString;
class WebWorker;
}
class WorkerDevToolsAgent {
public:
- WorkerDevToolsAgent(int route_id, WebKit::WebWorker*);
- ~WorkerDevToolsAgent();
+ static WorkerDevToolsAgent* CreateForDedicatedWorker(
+ int route_id,
+ WebKit::WebWorker*);
+ static WorkerDevToolsAgent* CreateForSharedWorker(
+ int route_id,
+ WebKit::WebSharedWorker*);
+ virtual ~WorkerDevToolsAgent();
- bool OnMessageReceived(const IPC::Message& message);
+ // Called on the Worker thread.
+ virtual bool OnMessageReceived(const IPC::Message& message) = 0;
+ virtual void SendDevToolsMessage(const WebKit::WebString&) = 0;
- void SendDevToolsMessage(const WebKit::WebString&);
-
- private:
- void OnAttach();
- void OnDetach();
- void OnDispatchOnInspectorBackend(const std::string& message);
+ protected:
+ explicit WorkerDevToolsAgent(int route_id);
bool Send(IPC::Message* message);
-
- int route_id_;
- WebKit::WebWorker* webworker_;
+ const int route_id_;
DISALLOW_COPY_AND_ASSIGN(WorkerDevToolsAgent);
};

Powered by Google App Engine
This is Rietveld 408576698