Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1318)

Unified Diff: content/browser/debugger/devtools_window.cc

Issue 7248076: DevTools: add initial support for shared workers debugging (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments addressed Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/debugger/devtools_window.cc
diff --git a/content/browser/debugger/devtools_window.cc b/content/browser/debugger/devtools_window.cc
index ba633243a70139c39ad1e464e43ead12f04f45bc..c231568fed70ab0a3a7135c426feb2e2383dbbcb 100644
--- a/content/browser/debugger/devtools_window.cc
+++ b/content/browser/debugger/devtools_window.cc
@@ -74,6 +74,12 @@ DevToolsWindow* DevToolsWindow::FindDevToolsWindow(
}
// static
+DevToolsWindow* DevToolsWindow::CreateDevToolsWindowForWorker(
+ Profile* profile) {
+ return new DevToolsWindow(profile, NULL, false);
+}
+
+// static
DevToolsWindow* DevToolsWindow::OpenDevToolsWindow(
RenderViewHost* inspected_rvh) {
return ToggleDevToolsWindow(inspected_rvh, true,
@@ -130,10 +136,12 @@ DevToolsWindow::DevToolsWindow(Profile* profile,
this,
NotificationType::BROWSER_THEME_CHANGED,
Source<ThemeService>(ThemeServiceFactory::GetForProfile(profile_)));
- TabContents* tab = inspected_rvh->delegate()->GetAsTabContents();
- if (tab)
- inspected_tab_ = TabContentsWrapper::GetCurrentWrapperForContents(tab);
-
+ // There is now inspected_rvh in case of shared workers.
pfeldman 2011/07/11 12:07:16 There is _no_ inspected_rvh ?
yurys 2011/07/11 15:13:11 Done.
+ if (inspected_rvh) {
+ TabContents* tab = inspected_rvh->delegate()->GetAsTabContents();
+ if (tab)
+ inspected_tab_ = TabContentsWrapper::GetCurrentWrapperForContents(tab);
+ }
instances_.push_back(this);
}

Powered by Google App Engine
This is Rietveld 408576698