Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 7248065: Changed fontlist to list Osaka-Mono

Created:
9 years, 5 months ago by keishi1
Modified:
6 years, 8 months ago
Reviewers:
keishi, csilv, commit-bot: I haz the power, nobuyoshi.miyokawa
CC:
chromium-reviews, joi+watch-content_chromium.org, jam
Visibility:
Public.

Description

Changed fontlist to list Osaka-Mono Osaka-Mono is the only monospaced Japanese font on the Mac but since it is inside the Osaka font-family it wasn't listed. This patch lists fonts that doesn't match its font family's fixed pitch trait. BUG=86734 TEST=manually. Open chrome://settings/fonts and confirm that Osaka-Mono is in the list menu. Select Osaka-Mono and confirms that the setting stays when you reopen.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed variable name #

Patch Set 3 : Rebased #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -16 lines) Patch
M chrome/browser/ui/webui/options/font_settings_utils_mac.mm View 1 2 2 chunks +14 lines, -5 lines 0 comments Download
M content/common/font_list_mac.mm View 1 2 3 1 chunk +49 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
keishi1
Moved patch from http://codereview.chromium.org/7204026/
9 years, 5 months ago (2011-07-04 09:55:38 UTC) #1
csilv
LGTM http://codereview.chromium.org/7248065/diff/1/content/common/font_list_mac.mm File content/common/font_list_mac.mm (right): http://codereview.chromium.org/7248065/diff/1/content/common/font_list_mac.mm#newcode52 content/common/font_list_mac.mm:52: NSArray* familyMembers = [font_manager availableMembersOfFontFamily: Nit: change variable ...
9 years, 5 months ago (2011-07-06 19:42:50 UTC) #2
keishi1
> content/common/font_list_mac.mm:52: NSArray* familyMembers = [font_manager > availableMembersOfFontFamily: > Nit: change variable name to family_members ...
9 years, 5 months ago (2011-07-07 02:52:26 UTC) #3
commit-bot: I haz the power
Presubmit check for 7248065-3001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 5 months ago (2011-07-07 02:52:41 UTC) #4
keishi1
Added test instructions.
9 years, 5 months ago (2011-07-07 04:38:57 UTC) #5
commit-bot: I haz the power
Presubmit check for 7248065-3001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 5 months ago (2011-07-07 22:58:37 UTC) #6
commit-bot: I haz the power
Presubmit check for 7248065-3001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 5 months ago (2011-07-12 11:33:30 UTC) #7
keishi
estade@ could you review font_settings_utils_mac.mm? Thanks.
7 years, 4 months ago (2013-08-21 12:12:09 UTC) #8
Evan Stade
7 years, 3 months ago (2013-08-26 20:52:54 UTC) #9
no, I have zero familiarity with objective c.

Powered by Google App Engine
This is Rietveld 408576698