Migrating PPB_FileIO_Dev, PPB_FileRef_Dev, and PPB_FileSystem_Dev dependencies to PPB_FileIO, PPB...

Migrating PPB_FileIO_Dev, PPB_FileRef_Dev, and PPB_FileSystem_Dev dependencies to PPB_FileIO, PPB_FileRef, and PPB_FileSystem.
Also fixed some lint errors.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91733

[piman, 2011-06-30 23:44:41]

drive-by: shouldn't APIs get rev'ed by this change ?

[Sang Ahn, 2011-07-01 14:43:13]

Yep,  they were rev'ed with this
<http://codereview.chromium.org/7261004/>change.

On Thu, Jun 30, 2011 at 5:44 PM, <piman@chromium.org> wrote:

> drive-by: shouldn't APIs get rev'ed by this change ?
>
>
http://codereview.chromium.**org/7248047/<http://codereview.chromium.org/7248...
>



-- 
Sang Wook Ahn

[Sang Ahn, 2011-07-01 21:26:28]

ping

On Thu, Jun 30, 2011 at 5:42 PM, <sanga@chromium.org> wrote:

> Reviewers: brettw, nfullagar,
>
> Description:
> Migrating PPB_FileIO_Dev, PPB_FileRef_Dev, and PPB_FileSystem_Dev
> dependencies
> to PPB_FileIO, PPB_FileRef, and PPB_FileSystem.
> Also fixed some lint errors.
>
> Please review this at
http://codereview.chromium.**org/7248047/<http://codereview.chromium.org/7248...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  M     ppapi/c/dev/ppb_directory_**reader_dev.h
>  M     ppapi/c/private/ppb_flash_**file.h
>  M     ppapi/cpp/dev/directory_entry_**dev.h
>  M     ppapi/cpp/dev/directory_**reader_dev.h
>  M     ppapi/cpp/dev/directory_**reader_dev.cc
>  M     ppapi/proxy/ppapi_messages.h
>  M     ppapi/proxy/ppapi_param_**traits.h
>  M     ppapi/proxy/ppapi_param_**traits.cc
>  M     ppapi/proxy/ppb_file_ref_**proxy.cc
>  M     ppapi/proxy/ppb_file_system_**proxy.h
>  M     ppapi/proxy/ppb_file_system_**proxy.cc
>  M     ppapi/proxy/ppb_flash_file_**proxy.h
>  M     ppapi/proxy/ppb_flash_file_**proxy.cc
>  M     ppapi/proxy/ppb_flash_proxy.h
>  M     ppapi/proxy/resource_creation_**proxy.h
>  M     ppapi/proxy/resource_creation_**proxy.cc
>  M     ppapi/proxy/serialized_**structs.h
>  M     ppapi/proxy/serialized_**structs.cc
>  M     ppapi/tests/all_c_includes.h
>  M     ppapi/tests/all_cpp_includes.h
>  M     ppapi/tests/test_directory_**reader.cc
>  M     ppapi/thunk/ppb_file_io_api.h
>  M     ppapi/thunk/ppb_file_io_thunk.**cc
>  M     ppapi/thunk/ppb_file_io_**trusted_thunk.cc
>  M     ppapi/thunk/ppb_file_ref_api.h
>  M     ppapi/thunk/ppb_file_ref_**thunk.cc
>  M     ppapi/thunk/ppb_file_system_**api.h
>  M     ppapi/thunk/ppb_file_system_**thunk.cc
>  M     ppapi/thunk/resource_creation_**api.h
>  M     ppapi/thunk/thunk.h
>  M     webkit/plugins/ppapi/file_**callbacks.h
>  M     webkit/plugins/ppapi/file_**callbacks.cc
>  M     webkit/plugins/ppapi/file_**type_conversions.cc
>  M     webkit/plugins/ppapi/plugin_**module.cc
>  M     webkit/plugins/ppapi/ppb_file_**io_impl.h
>  M     webkit/plugins/ppapi/ppb_file_**io_impl.cc
>  M     webkit/plugins/ppapi/ppb_file_**ref_impl.h
>  M     webkit/plugins/ppapi/ppb_file_**ref_impl.cc
>  M     webkit/plugins/ppapi/ppb_file_**system_impl.h
>  M     webkit/plugins/ppapi/ppb_file_**system_impl.cc
>  M     webkit/plugins/ppapi/ppb_**flash_file_impl.cc
>  M     webkit/plugins/ppapi/resource_**creation_impl.h
>  M     webkit/plugins/ppapi/resource_**creation_impl.cc
>
>
>


-- 
Sang Wook Ahn

[nfullagar, 2011-07-02 00:16:45]

couple of nits, otherwise looks good from here...

http://codereview.chromium.org/7248047/diff/8001/ppapi/proxy/ppapi_messages.h
File ppapi/proxy/ppapi_messages.h (right):

http://codereview.chromium.org/7248047/diff/8001/ppapi/proxy/ppapi_messages.h...
ppapi/proxy/ppapi_messages.h:21: #include "ppapi/c/pp_file_info.h"
pp_bool... comes before pp_file...

http://codereview.chromium.org/7248047/diff/8001/ppapi/proxy/ppapi_param_trai...
File ppapi/proxy/ppapi_param_traits.h (right):

http://codereview.chromium.org/7248047/diff/8001/ppapi/proxy/ppapi_param_trai...
ppapi/proxy/ppapi_param_traits.h:9: #include <vector>
curious why this is needed now?

http://codereview.chromium.org/7248047/diff/8001/webkit/plugins/ppapi/plugin_...
File webkit/plugins/ppapi/plugin_module.cc (right):

http://codereview.chromium.org/7248047/diff/8001/webkit/plugins/ppapi/plugin_...
webkit/plugins/ppapi/plugin_module.cc:271: if (strcmp(name,
"PPB_FileIO(Dev);0.3") == 0)
Is it possible to use PPB_FILEIO_DEV_INTERFACE, etc. or do you get conflicts on
the enums?

[brettw, 2011-07-06 16:00:34]

LGTM

http://codereview.chromium.org/7248047/diff/8001/ppapi/proxy/ppapi_param_trai...
File ppapi/proxy/ppapi_param_traits.h (right):

http://codereview.chromium.org/7248047/diff/8001/ppapi/proxy/ppapi_param_trai...
ppapi/proxy/ppapi_param_traits.h:9: #include <vector>
I think he was fixing lint errors. Thanks!

http://codereview.chromium.org/7248047/diff/19001/ppapi/proxy/serialized_stru...
File ppapi/proxy/serialized_structs.cc (right):

http://codereview.chromium.org/7248047/diff/19001/ppapi/proxy/serialized_stru...
ppapi/proxy/serialized_structs.cc:9: #include "ppapi/c/pp_file_info.h"
Should be moved above to be in order.

http://codereview.chromium.org/7248047/diff/19001/webkit/plugins/ppapi/file_c...
File webkit/plugins/ppapi/file_callbacks.cc (right):

http://codereview.chromium.org/7248047/diff/19001/webkit/plugins/ppapi/file_c...
webkit/plugins/ppapi/file_callbacks.cc:8: #include "ppapi/c/pp_file_info.h"
Should be below to be in order.

http://codereview.chromium.org/7248047/diff/19001/webkit/plugins/ppapi/file_t...
File webkit/plugins/ppapi/file_type_conversions.cc (right):

http://codereview.chromium.org/7248047/diff/19001/webkit/plugins/ppapi/file_t...
webkit/plugins/ppapi/file_type_conversions.cc:7: #include
"ppapi/c/ppb_file_io.h"
Should be below.

http://codereview.chromium.org/7248047/diff/19001/webkit/plugins/ppapi/plugin...
File webkit/plugins/ppapi/plugin_module.cc (right):

http://codereview.chromium.org/7248047/diff/19001/webkit/plugins/ppapi/plugin...
webkit/plugins/ppapi/plugin_module.cc:264: // Support the dev interfaces for
file io, fileref and file system
Can you put this condition below with the GL stuff so all the "regular"
interfaces are in one block?

http://codereview.chromium.org/7248047/diff/19001/webkit/plugins/ppapi/plugin...
webkit/plugins/ppapi/plugin_module.cc:271: if (strcmp(name,
"PPB_FileIO(Dev);0.3") == 0)
There are no defines for the dev version, the define points to the new non-dev
version.

[sanga, 2011-07-06 16:18:59]

http://codereview.chromium.org/7248047/diff/8001/ppapi/proxy/ppapi_messages.h
File ppapi/proxy/ppapi_messages.h (right):

http://codereview.chromium.org/7248047/diff/8001/ppapi/proxy/ppapi_messages.h...
ppapi/proxy/ppapi_messages.h:21: #include "ppapi/c/pp_file_info.h"
On 2011/07/02 00:16:45, nfullagar wrote:
> pp_bool... comes before pp_file...

Done.

http://codereview.chromium.org/7248047/diff/8001/ppapi/proxy/ppapi_param_trai...
File ppapi/proxy/ppapi_param_traits.h (right):

http://codereview.chromium.org/7248047/diff/8001/ppapi/proxy/ppapi_param_trai...
ppapi/proxy/ppapi_param_traits.h:9: #include <vector>
I'm addressing some lint errors. 
On 2011/07/02 00:16:45, nfullagar wrote:
> curious why this is needed now?

http://codereview.chromium.org/7248047/diff/8001/webkit/plugins/ppapi/plugin_...
File webkit/plugins/ppapi/plugin_module.cc (right):

http://codereview.chromium.org/7248047/diff/8001/webkit/plugins/ppapi/plugin_...
webkit/plugins/ppapi/plugin_module.cc:271: if (strcmp(name,
"PPB_FileIO(Dev);0.3") == 0)
Yes, I get enum type value conflicts.
On 2011/07/02 00:16:45, nfullagar wrote:
> Is it possible to use PPB_FILEIO_DEV_INTERFACE, etc. or do you get conflicts
on
> the enums?

http://codereview.chromium.org/7248047/diff/19001/ppapi/proxy/serialized_stru...
File ppapi/proxy/serialized_structs.cc (right):

http://codereview.chromium.org/7248047/diff/19001/ppapi/proxy/serialized_stru...
ppapi/proxy/serialized_structs.cc:9: #include "ppapi/c/pp_file_info.h"
On 2011/07/06 16:00:34, brettw wrote:
> Should be moved above to be in order.

Done.

http://codereview.chromium.org/7248047/diff/19001/webkit/plugins/ppapi/file_c...
File webkit/plugins/ppapi/file_callbacks.cc (right):

http://codereview.chromium.org/7248047/diff/19001/webkit/plugins/ppapi/file_c...
webkit/plugins/ppapi/file_callbacks.cc:8: #include "ppapi/c/pp_file_info.h"
On 2011/07/06 16:00:34, brettw wrote:
> Should be below to be in order.

Done.

http://codereview.chromium.org/7248047/diff/19001/webkit/plugins/ppapi/file_t...
File webkit/plugins/ppapi/file_type_conversions.cc (right):

http://codereview.chromium.org/7248047/diff/19001/webkit/plugins/ppapi/file_t...
webkit/plugins/ppapi/file_type_conversions.cc:7: #include
"ppapi/c/ppb_file_io.h"
On 2011/07/06 16:00:34, brettw wrote:
> Should be below.

Done.

http://codereview.chromium.org/7248047/diff/19001/webkit/plugins/ppapi/plugin...
File webkit/plugins/ppapi/plugin_module.cc (right):

http://codereview.chromium.org/7248047/diff/19001/webkit/plugins/ppapi/plugin...
webkit/plugins/ppapi/plugin_module.cc:264: // Support the dev interfaces for
file io, fileref and file system
On 2011/07/06 16:00:34, brettw wrote:
> Can you put this condition below with the GL stuff so all the "regular"
> interfaces are in one block?

Done.