Support for [Clamp] and [EnforceRange] to IDL dictionary.

Source/bindings/templates/dictionary_v8.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file has been auto-generated by {{code_generator}}. DO NOT MODIFY!
 
 #include "config.h"
 #include "{{v8_class}}.h"
 
 {% for filename in cpp_includes if filename != '%s.h' % v8_class %}
@@ skipping 10 matching lines @@
         exceptionState.throwTypeError("cannot convert to dictionary.");
         return;
     }
 
     {% if parent_v8_class %}
     {{parent_v8_class}}::toImpl(isolate, v8Value, impl, exceptionState);
     if (exceptionState.hadException())
         return;
 
     {% endif %}
-    // FIXME: Do not use Dictionary and DictionaryHelper
-    // https://crbug.com/321462
-    Dictionary dictionary(v8Value, isolate);
-    // FIXME: Remove this v8::TryCatch once the code is switched from
-    // Dictionary/DictionaryHelper to something that uses ExceptionState.
+
+    v8::Local<v8::Object> v8Object = v8Value->ToObject(isolate);
     v8::TryCatch block;
     {% for member in members %}
-    {{member.cpp_type}} {{member.name}};
-    if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "{{member.name}}", {{member.name}})) {
+    v8::Local<v8::Value> {{member.name}}Value = v8Object->Get(v8String(isolate, "{{member.name}}"));
+    if (!{{member.name}}Value.IsEmpty() && !isUndefinedOrNull({{member.name}}Value)) {
+        {{member.v8_value_to_local_cpp_value}};
     {% if member.enum_validation_expression %}
         String string = {{member.name}};
         if (!({{member.enum_validation_expression}})) {
             exceptionState.throwTypeError("member {{member.name}} ('" + string + "') is not a valid enum value.");
             return;
         }
     {% elif member.is_object %}
         if (!{{member.name}}.isObject()) {
             exceptionState.throwTypeError("member {{member.name}} is not an object.");
             return;
         }
     {% endif %}
         impl.{{member.setter_name}}({{member.name}});
     } else if (block.HasCaught()) {
         exceptionState.rethrowV8Exception(block.Exception());
-        return;

[zino, 2014/11/19 18:12:19]

This is my mistake.. :-(

[bashi, 2014/11/20 02:18:02]

I'm not sure why you removed this return. Early exit when an error occurs is a
good thing, no?

[zino, 2014/11/20 02:40:43]

Yep, you're right! It's just my mistake :-P

     }
 
     {% endfor %}
 }
 
 v8::Handle<v8::Value> toV8({{cpp_class}}& impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
 {
     v8::Handle<v8::Object> v8Object = v8::Object::New(isolate);
     {% if parent_v8_class %}
     toV8{{parent_cpp_class}}(impl, v8Object, creationContext, isolate);
@@ skipping 13 matching lines @@
     {% if member.v8_default_value %}
     } else {
         dictionary->Set(v8String(isolate, "{{member.name}}"), {{member.v8_default_value}});
     {% endif %}
     }
 
     {% endfor %}
 }
 
 } // namespace blink