Support for [Clamp] and [EnforceRange] to IDL dictionary.

Source/bindings/templates/dictionary_v8.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file has been auto-generated by {{code_generator}}. DO NOT MODIFY!
 
 #include "config.h"
 #include "{{v8_class}}.h"
 
 {% for filename in cpp_includes if filename != '%s.h' % v8_class %}
 #include "{{filename}}"
 {% endfor %}
 
 namespace blink {
 
 void {{v8_class}}::toImpl(v8::Isolate* isolate, v8::Handle<v8::Value> v8Value, {{cpp_class}}& impl, ExceptionState& exceptionState)
 {
     if (isUndefinedOrNull(v8Value))
         return;
     if (!v8Value->IsObject()) {
         exceptionState.throwTypeError("cannot convert to dictionary.");
         return;
     }
 
     // FIXME: Do not use Dictionary and DictionaryHelper
     // https://crbug.com/321462
     Dictionary dictionary(v8Value, isolate);
     // FIXME: Remove this v8::TryCatch once the code is switched from
     // Dictionary/DictionaryHelper to something that uses ExceptionState.
     v8::TryCatch block;

[bashi, 2014/11/17 02:20:45]

I think you can fix this FIXME in this CL or a follow-up CL:)

v8_value_to_local_cpp_value can handle ExceptionState.

[zino, 2014/11/19 18:12:19]

I'm trying to fix this but I'm not familiar with this part.
How can I handle the ExceptionState without v8::TryCatch.
Please see Patch Set 4 (not Set 5) and
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/...

[bashi, 2014/11/20 02:18:02]

Hmm, let me investigate it later. I think I can fix it. This CL shouldn't affect
custom elements tests so please leave this as is. Sorry for the noise.

     {% for member in members %}
-    {{member.cpp_type}} {{member.name}};
-    if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "{{member.name}}", {{member.name}})) {
+    v8::Local<v8::Value> {{member.name}}Value;
+    if (dictionary.getKey("{{member.name}}", {{member.name}}Value) && !isUndefinedOrNull({{member.name}}Value)) {

[haraken, 2014/11/17 00:22:19]

Is getWithUndefinedOrNullCheck still needed? It's confusing to have two ways to
get a dictionary value: getWithUndefinedOrNullCheck and 'getKey &&
isUndefinedOrNull'?

[bashi, 2014/11/17 02:20:45]

Also, we can remove Dictionary here if you use v8_value_to_local_cpp_value.
Dictionary::getKey() is just a wrapper of getting a property from a V8 object.
You can add a static function instead (which will take v8::Local<v8::Object> and
String, returning a v8::Local<v8::Value>.

[zino, 2014/11/19 18:12:19]

Done.

+        {{member.v8_value_to_local_cpp_value}};
     {% if member.enum_validation_expression %}
         String string = {{member.name}};
         if (!({{member.enum_validation_expression}})) {
             exceptionState.throwTypeError("member {{member.name}} ('" + string + "') is not a valid enum value.");
             return;
         }
     {% elif member.is_object %}
         if (!{{member.name}}.isObject()) {
             exceptionState.throwTypeError("member {{member.name}} is not an object.");
             return;
@@ skipping 21 matching lines @@
     } else {
         v8Object->Set(v8String(isolate, "{{member.name}}"), {{member.v8_default_value}});
     {% endif %}
     }
 
     {% endfor %}
     return v8Object;
 }
 
 } // namespace blink