Add remembered virtual networks to NetworkLibrary and internet options.

Add remembered virtual networks to NetworkLibrary and internet options.
Also, request virtual networks from flimflam for any remembered virtual networks so that they can be connected to.

BUG=chromium-os:16230, chromium-os:16229
TEST=See issue for test plan.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90439

[James Cook, 2011-06-23 22:22:46]

One question about copying credentials.

http://codereview.chromium.org/7247021/diff/1/chrome/browser/chromeos/cros/ne...
File chrome/browser/chromeos/cros/network_library.cc (right):

http://codereview.chromium.org/7247021/diff/1/chrome/browser/chromeos/cros/ne...
chrome/browser/chromeos/cros/network_library.cc:1446: if (ca_cert_nss_.empty())
Why do we only overwrite fields that aren't empty?  Should it be all-or-none?

http://codereview.chromium.org/7247021/diff/1/chrome/browser/chromeos/cros/ne...
chrome/browser/chromeos/cros/network_library.cc:4819: VirtualNetwork*
remembered_vpn2 = new VirtualNetwork("fv2");
Hooray for more stubs!

[stevenjb, 2011-06-23 23:51:18]

http://codereview.chromium.org/7247021/diff/1/chrome/browser/chromeos/cros/ne...
File chrome/browser/chromeos/cros/network_library.cc (right):

http://codereview.chromium.org/7247021/diff/1/chrome/browser/chromeos/cros/ne...
chrome/browser/chromeos/cros/network_library.cc:1446: if (ca_cert_nss_.empty())
On 2011/06/23 22:22:46, James Cook (Chromium) wrote:
> Why do we only overwrite fields that aren't empty?  Should it be all-or-none?
If an existing network has a value set, it might have been set more recently
through the UI, and it will never be less recent than the remembered value.
I changed the function to CopyCredentialsFromRemembered and updated the comment
in the header.

http://codereview.chromium.org/7247021/diff/1/chrome/browser/chromeos/cros/ne...
chrome/browser/chromeos/cros/network_library.cc:4819: VirtualNetwork*
remembered_vpn2 = new VirtualNetwork("fv2");
On 2011/06/23 22:22:46, James Cook (Chromium) wrote:
> Hooray for more stubs!
:)

[James Cook, 2011-06-23 23:53:39]

LGTM

[kmixter1, 2011-06-24 16:09:26]

FYI

http://codereview.chromium.org/7247021/diff/4001/chrome/browser/chromeos/cros...
File chrome/browser/chromeos/cros/network_library.cc (right):

http://codereview.chromium.org/7247021/diff/4001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/network_library.cc:2306: if (encryption_ ==
SECURITY_8021X && eap_method_ != EAP_METHOD_PEAP)
If I'm reading this right (what are networks that require a user to be logged
in) this should be less restrictive:

return (encryption_ == SECURITY_8021X && eap_method_ == EAP_TLS);

Specifically TTLS and LEAP both don't require being logged in.

[stevenjb, 2011-06-24 17:32:05]

http://codereview.chromium.org/7247021/diff/4001/chrome/browser/chromeos/cros...
File chrome/browser/chromeos/cros/network_library.cc (right):

http://codereview.chromium.org/7247021/diff/4001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/network_library.cc:2306: if (encryption_ ==
SECURITY_8021X && eap_method_ != EAP_METHOD_PEAP)
On 2011/06/24 16:09:26, kmixter1 wrote:
> If I'm reading this right (what are networks that require a user to be logged
> in) this should be less restrictive:
> 
> return (encryption_ == SECURITY_8021X && eap_method_ == EAP_TLS);
> 
> Specifically TTLS and LEAP both don't require being logged in.

Done, but also checked eap_client_cert_pkcs11_id().empty() so that if we add
another method that allows setting a client cert, we will store it in the user
profile.

[kmixter1, 2011-06-24 18:13:45]

LGTM

[zel, 2011-06-24 19:00:42]

LGTM

the CL seems safe for M13 merge