Keyboard should not be displayed in tab switcher mode.

chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java

Index: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
diff --git a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
index 74619f9173f90f557b52a85ea0beedfb59d5e64c..c957f49641a553dbab9451bdeb45e1527cd54cbf 100644
--- a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
+++ b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
@@ -76,6 +76,7 @@ public class ChromeShellToolbar extends LinearLayout {
     private ImageButton mAddButton;
     private int mProgress = 0;
     private boolean mLoading = true;
+    private boolean mHasFocus = false;
 
     /**
      * @param context The Context the view is running in.
@@ -181,6 +182,7 @@ public class ChromeShellToolbar extends LinearLayout {
         mUrlTextView.setOnFocusChangeListener(new OnFocusChangeListener() {
             @Override
             public void onFocusChange(View v, boolean hasFocus) {
+                mHasFocus = hasFocus;
                 setKeyboardVisibilityForUrl(hasFocus);
                 mStopReloadButton.setVisibility(hasFocus ? GONE : VISIBLE);
                 if (!hasFocus && mTab != null) {
@@ -266,6 +268,8 @@ public class ChromeShellToolbar extends LinearLayout {
     public void showAddButton(boolean visibility) {
         mAddButton.setVisibility(visibility ? VISIBLE : GONE);
         mStopReloadButton.setVisibility(visibility ? GONE : VISIBLE);
+        if (visibility)
+            setKeyboardVisibilityForUrl(mHasFocus);

[Bernhard Bauer, 2014/11/13 09:35:09]

I don't understand this. If |mHasFocus| is false at this point, it means that we
must have executed line 185 to set it to false, but then the next line would
have hidden the keyboard anyway. Under what circumstances does the visibility of
the keyboard get out of sync with the focus of the text field?

[divya.bansal, 2014/11/13 09:49:07]

@Bernhard this case is when focus is not on url field. if focus is on text field
then keyboard appears but hasFocus is false then if we switch on to tab manager
then keyboard should go away. Because focus is not on url field and in tab
manager window only edit field is url field.

[Bernhard Bauer, 2014/11/13 10:06:30]

Could we achieve this by unfocusing the text field when opening the tab
switcher? I don't see why it should be the responsibility of the toolbar to hide
the keyboard if a text field in the content area is focused, or why it should do
that in this method (which is supposed to show or hide the add tab button).

[divya.bansal, 2014/11/13 10:34:00]

But if we unfocus the text field on opening the tab switcher then that focus
will be lost when we come back on that URL. Currently in Chrome Beta also, after
going to tab switcher and coming back focus is on same text box.

[Bernhard Bauer, 2014/11/13 10:45:35]

Okay, I see.

Could we simply hide the keyboard when activating the tab switcher? The URL
field is bit useless when the tab switcher is visible anyway.

The other thing that is a little dirty is that setKeyboardVisibilityForUrl()
assumes that the URL field is currently focused and uses its window token, which
is not the case here. Technically, we should use the window token from the
content view, which is also why I'm thinking this might be better done in the
TabManager or so.

[divya.bansal, 2014/11/13 11:47:51]

Done.

     }
 
     /**