Source/core/page/EventHandler.cpp - Issue 724673003: Don't make :hover sticky on tap on sites that set a mobile viewport set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/EventHandler.cpp

Issue 724673003: Don't make :hover sticky on tap on sites that set a mobile viewport set (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Don't make :hover sticky on tap on sites that set a mobile viewport set Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/EventHandler.cpp

diff --git a/Source/core/page/EventHandler.cpp b/Source/core/page/EventHandler.cpp

index 3d1279c3b704166d04a0ca9dd72322472a2267e8..5d61874f11dee82915ac6ba8b05a4c4010bff693 100644

--- a/Source/core/page/EventHandler.cpp

+++ b/Source/core/page/EventHandler.cpp

@@ -2663,7 +2663,8 @@ HitTestRequest::HitTestRequestType EventHandler::getHitTypeForGestureType(Platfo

// A TapDownCancel received when no element is active shouldn't really be changing hover state.

if (!m_frame->document()->activeHoverElement())

hitType |= HitTestRequest::ReadOnly;

- return hitType | HitTestRequest::Release;

+ // allow :hover style to be sticky after long press

+ return hitType | HitTestRequest::Release | HitTestRequest::Hover;

USE s.singapati at gmail.com 2014/11/13 10:30:57 Retained "Release" flag to not break any other tha

case PlatformEvent::GestureTap:

return hitType | HitTestRequest::Release;

case PlatformEvent::GestureTapDown:

« Source/core/dom/Document.cpp ('K') | « Source/core/dom/Document.cpp ('k') | Source/core/rendering/HitTestRequest.h » ('j') | Source/core/rendering/HitTestRequest.h » ('J')