Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Side by Side Diff: Source/web/ChromeClientImpl.h

Issue 724673003: Don't make :hover sticky on tap on sites that set a mobile viewport set (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Refactored logic and corrected viewport checking Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/HitTestRequest.h ('k') | Source/web/ChromeClientImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 166
167 virtual void didAssociateFormControls(const WillBeHeapVector<RefPtrWillBeMem ber<Element> >&) override; 167 virtual void didAssociateFormControls(const WillBeHeapVector<RefPtrWillBeMem ber<Element> >&) override;
168 virtual void didChangeValueInTextField(HTMLFormControlElement&) override; 168 virtual void didChangeValueInTextField(HTMLFormControlElement&) override;
169 virtual void didEndEditingOnTextField(HTMLInputElement&) override; 169 virtual void didEndEditingOnTextField(HTMLInputElement&) override;
170 virtual void handleKeyboardEventOnTextField(HTMLInputElement&, KeyboardEvent &) override; 170 virtual void handleKeyboardEventOnTextField(HTMLInputElement&, KeyboardEvent &) override;
171 171
172 virtual void didCancelCompositionOnSelectionChange() override; 172 virtual void didCancelCompositionOnSelectionChange() override;
173 virtual void willSetInputMethodState() override; 173 virtual void willSetInputMethodState() override;
174 virtual void didUpdateTextOfFocusedElementByNonUserInput() override; 174 virtual void didUpdateTextOfFocusedElementByNonUserInput() override;
175 virtual void showImeIfNeeded() override; 175 virtual void showImeIfNeeded() override;
176 virtual bool shouldDisableDesktopWorkarounds() override;
176 177
177 private: 178 private:
178 virtual bool isChromeClientImpl() const override { return true; } 179 virtual bool isChromeClientImpl() const override { return true; }
179 180
180 WebNavigationPolicy getNavigationPolicy(); 181 WebNavigationPolicy getNavigationPolicy();
181 void setCursor(const WebCursorInfo&); 182 void setCursor(const WebCursorInfo&);
182 183
183 WebViewImpl* m_webView; // weak pointer 184 WebViewImpl* m_webView; // weak pointer
184 bool m_toolbarsVisible; 185 bool m_toolbarsVisible;
185 bool m_statusbarVisible; 186 bool m_statusbarVisible;
186 bool m_scrollbarsVisible; 187 bool m_scrollbarsVisible;
187 bool m_menubarVisible; 188 bool m_menubarVisible;
188 bool m_resizable; 189 bool m_resizable;
189 190
190 PagePopupDriver* m_pagePopupDriver; 191 PagePopupDriver* m_pagePopupDriver;
191 }; 192 };
192 193
193 DEFINE_TYPE_CASTS(ChromeClientImpl, ChromeClient, client, client->isChromeClient Impl(), client.isChromeClientImpl()); 194 DEFINE_TYPE_CASTS(ChromeClientImpl, ChromeClient, client, client->isChromeClient Impl(), client.isChromeClientImpl());
194 195
195 } // namespace blink 196 } // namespace blink
196 197
197 #endif 198 #endif
OLDNEW
« no previous file with comments | « Source/core/rendering/HitTestRequest.h ('k') | Source/web/ChromeClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698