Chromium Code Reviews Chromium Code Reviews
Issue 724663002:
Don't abort drags if drag image generation fails. (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| Index: LayoutTests/fast/events/setDragImage-with-detached-node.html |
| diff --git a/LayoutTests/fast/events/setDragImage-with-detached-node.html b/LayoutTests/fast/events/setDragImage-with-detached-node.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..ec97f912f16fbf7766bbd687726661b9fe2039c7 |
| --- /dev/null |
| +++ b/LayoutTests/fast/events/setDragImage-with-detached-node.html |
| @@ -0,0 +1,65 @@ |
| +<!DOCTYPE html> |
| +<html> |
|
Rick Byers
2014/11/13 22:22:19
nit: omit html, head: http://www.chromium.org/blin
dcheng
2014/11/13 22:29:30
Done.
|
| +<head> |
| +<script src="../../resources/js-test.js"></script> |
| +<script> |
| +var dragEndExpected = true; |
| + |
| +function runTest() |
| +{ |
| + var dragger = document.getElementById('dragMe'); |
| + dragger.addEventListener('dragstart', dragStart); |
| + dragger.addEventListener('drag', dragging); |
| + dragger.addEventListener('dragend', dragEnd); |
| + if (!window.testRunner) |
| + return; |
| + |
| + var x = dragger.offsetLeft + dragger.offsetWidth / 2; |
| + var y = dragger.offsetTop + dragger.offsetHeight / 2; |
| + |
| + eventSender.mouseMoveTo(x, y); |
| + eventSender.mouseDown(); |
| + eventSender.leapForward(100); |
| + eventSender.mouseMoveTo(x + 100, y + 100); |
| + eventSender.mouseUp(); |
| +} |
| + |
| +function dragStart(e) |
| +{ |
| + if (window.testRunner) |
| + dragEndExpected = false; |
| + debug('Started drag.'); |
| + var emptyDiv = document.createElement('div'); |
| + e.dataTransfer.setDragImage(emptyDiv, 0, 0); |
| +} |
| + |
| +function dragging() |
| +{ |
| + dragEndExpected = true; |
| +} |
| + |
| +function dragEnd() |
| +{ |
| + if (!dragEndExpected) |
| + testFailed('Not expecting drag end!'); |
| + else |
| + testPassed('Ended drag.'); |
| +} |
| +</script> |
| +<style> |
| +html, body { |
| + height: 100%; |
| + margin: 0; |
| +} |
| + |
| +#dragMe { |
| + border: 1px solid black; |
| +} |
| +</style> |
| +</head> |
| +<body onload="runTest()"> |
|
Rick Byers
2014/11/13 22:22:19
nit: you can replace this with window.onload = fun
dcheng
2014/11/13 22:29:30
Done.
|
| +<p>Test that calling setDragImage() with a detached node doesn't immediately abort the drag. This test can be manually run by dragging the 'Drag Me' div around and then ending the drag. |
| +<div id="dragMe" draggable="true">Drag Me</div> |
| +<div id="console"></div> |
| +</body> |
| +</html> |
