Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 724663002: Don't abort drags if drag image generation fails. (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
Reviewers:
Rick Byers
CC:
dcheng, blink-reviews
Project:
blink
Visibility:
Public.

Description

Don't abort drags if drag image generation fails. This unintuitively caused drags to end immediately if a page called setDragImage with a detached node or one that hadn't been through layout yet. There's nothing in the spec that says the drags should abort in this case either, so this makes Blink more spec-conformant. BUG=413795 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185343

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -2 lines) Patch
A LayoutTests/fast/events/setDragImage-with-detached-node.html View 1 1 chunk +61 lines, -0 lines 0 comments Download
A LayoutTests/fast/events/setDragImage-with-detached-node-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/page/DragController.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
6 years, 1 month ago (2014-11-13 16:49:02 UTC) #2
Rick Byers
LGTM with test nits https://codereview.chromium.org/724663002/diff/1/LayoutTests/fast/events/setDragImage-with-detached-node.html File LayoutTests/fast/events/setDragImage-with-detached-node.html (right): https://codereview.chromium.org/724663002/diff/1/LayoutTests/fast/events/setDragImage-with-detached-node.html#newcode2 LayoutTests/fast/events/setDragImage-with-detached-node.html:2: <html> nit: omit html, head: ...
6 years, 1 month ago (2014-11-13 22:22:19 UTC) #3
dcheng
https://codereview.chromium.org/724663002/diff/1/LayoutTests/fast/events/setDragImage-with-detached-node.html File LayoutTests/fast/events/setDragImage-with-detached-node.html (right): https://codereview.chromium.org/724663002/diff/1/LayoutTests/fast/events/setDragImage-with-detached-node.html#newcode2 LayoutTests/fast/events/setDragImage-with-detached-node.html:2: <html> On 2014/11/13 22:22:19, Rick Byers wrote: > nit: ...
6 years, 1 month ago (2014-11-13 22:29:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/724663002/20001
6 years, 1 month ago (2014-11-13 22:30:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/36431)
6 years, 1 month ago (2014-11-14 00:32:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/724663002/20001
6 years, 1 month ago (2014-11-14 00:34:34 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 02:33:15 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 185343

Powered by Google App Engine
This is Rietveld 408576698