Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 724613004: clang-format/java: Do not use "all params on one line, or one line per param" for Java. (Closed)

Created:
6 years, 1 month ago by Nico
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

clang-format/java: Do not use "all params on one line, or one line per param" for Java. BUG=429372 NOTRY=true Committed: https://crrev.com/ed9dbf9e433a30ec55bc5ae10c097dc32845e097 Cr-Commit-Position: refs/heads/master@{#304923}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M .clang-format View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Nico
This still isn't right as parameters are still indented relative to the call's opening ( ...
6 years, 1 month ago (2014-11-14 19:00:49 UTC) #2
aurimas (slooooooooow)
lgtm
6 years, 1 month ago (2014-11-14 19:01:38 UTC) #3
aurimas (slooooooooow)
ping?
6 years, 1 month ago (2014-11-19 23:27:04 UTC) #4
Nico
On 2014/11/19 23:27:04, aurimas wrote: > ping? Sorry, didn't realize I didn't commit this. Should ...
6 years, 1 month ago (2014-11-19 23:38:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/724613004/1
6 years, 1 month ago (2014-11-19 23:39:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-19 23:41:01 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 23:41:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed9dbf9e433a30ec55bc5ae10c097dc32845e097
Cr-Commit-Position: refs/heads/master@{#304923}

Powered by Google App Engine
This is Rietveld 408576698