Issue 724613002: Add a version of flights that's made of components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 724613002: Add a version of flights that's made of components. (Closed)

Created:
6 years, 1 month ago by esprehn

Modified:
6 years, 1 month ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Add a version of flights that's made of components. Also add a test, this checks nested Shadow DOM and <content> with and without select. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e8fdb90bca3120d1c991256a2adf83a8315bf867

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+414 lines, -119 lines)			Patch
A	sky/examples/flights-app/app-header.sky	View	1 chunk	+18 lines, -0 lines	0 comments	Download
A	sky/examples/flights-app/app-menu-button.sky	View	1 chunk	+19 lines, -0 lines	0 comments	Download
A	sky/examples/flights-app/app-panel.sky	View	1 chunk	+16 lines, -0 lines	0 comments	Download
A	sky/examples/flights-app/app-panel-content.sky	View	1 chunk	+14 lines, -0 lines	0 comments	Download
A	sky/examples/flights-app/app-panel-header.sky	View	1 chunk	+17 lines, -0 lines	0 comments	Download
A	sky/examples/flights-app/app-scrollable.sky	View	1 chunk	+16 lines, -0 lines	0 comments	Download
A	sky/examples/flights-app/app-search-input.sky	View	1 chunk	+23 lines, -0 lines	0 comments	Download
A	sky/examples/flights-app/app-title.sky	View	1 chunk	+18 lines, -0 lines	0 comments	Download
A	sky/examples/flights-app/app-toast.sky	View	1 chunk	+36 lines, -0 lines	0 comments	Download
A	sky/examples/flights-app/app-toolbar.sky	View	1 chunk	+15 lines, -0 lines	0 comments	Download
A +	sky/examples/flights-app/flights-app.sky	View	13 chunks	+37 lines, -119 lines	0 comments	Download
A	sky/examples/flights-app/index.sky	View	1 chunk	+15 lines, -0 lines	0 comments	Download
A	sky/tests/framework/flights-app.sky	View	1 chunk	+10 lines, -0 lines	0 comments	Download
A	sky/tests/framework/flights-app-expected.txt	View	1 chunk	+160 lines, -0 lines	0 comments	Download

Total messages: 3 (1 generated)

esprehn

6 years, 1 month ago (2014-11-13 02:42:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e8fdb90bca3120d1c991256a2adf83a8315bf867 (presubmit successful).