ui/accessibility/accessibility_unittests.isolate - Issue 724603004: Isolate remaining tests under ui/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/accessibility/accessibility_unittests.isolate

Issue 724603004: Isolate remaining tests under ui/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2013 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 {	4 {

5 'includes': [

6 '../base/base.isolate',

7 ],

8 'conditions': [	5 'conditions': [

9 ['OS=="android" or OS=="linux" or OS=="mac" or OS=="win"', {	6 ['OS=="android" or OS=="linux" or OS=="mac" or OS=="win"', {
	M-A Ruel 2014/12/08 14:56:15 I don't think this test will ever be executed on a I don't think this test will ever be executed on android, so having this condition could be misleading to someone who reads this file. I'd recommend to remove android on each new file you added.
10 'variables': {	7 'variables': {

11 'command': [	8 'command': [

12 '<(PRODUCT_DIR)/angle_unittests<(EXECUTABLE_SUFFIX)',	9 '<(PRODUCT_DIR)/accessibility_unittests<(EXECUTABLE_SUFFIX)',

13 ],	10 ],

14 'files': [	11 'files': [

15 '<(PRODUCT_DIR)/angle_unittests<(EXECUTABLE_SUFFIX)',	12 '<(PRODUCT_DIR)/accessibility_unittests<(EXECUTABLE_SUFFIX)',

16 ],	13 ],

17 },	14 },

18 }],	15 }],

19 ],	16 ],

	17 'includes': [

	18 '../../base/base.isolate',

	19 ],

20 }	20 }

OLD	NEW