Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 7245013: Checking that items exist in the downloads panel on ChromeOS. (Closed)

Created:
9 years, 6 months ago by achuithb
Modified:
9 years, 5 months ago
CC:
chromium-reviews, rdsmith+dwatch_chromium.org
Visibility:
Public.

Description

Checking that items exist in the downloads panel on ChromeOS. BUG=chromium-os:16914 TEST=Download browser tests should continue to pass on all platforms. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90634

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 7

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Total comments: 3

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/download/download_browsertest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
achuithb
I added some support to access the downloads list from the download panel here: http://codereview.chromium.org/7241007/ ...
9 years, 6 months ago (2011-06-24 00:10:06 UTC) #1
achuithb
Also modified the comments so they are consistent everywhere.
9 years, 6 months ago (2011-06-24 00:11:30 UTC) #2
Paweł Hajdan Jr.
Drive-by with testing comments. No need to wait for me if you just apply all ...
9 years, 6 months ago (2011-06-24 08:36:33 UTC) #3
Randy Smith (Not in Mondays)
Achuith, two high level questions: * Can we do the same check in Chrome main ...
9 years, 6 months ago (2011-06-24 17:39:54 UTC) #4
achuithb
PTAL. On 2011/06/24 17:39:54, rdsmith wrote: > Achuith, two high level questions: > > * ...
9 years, 6 months ago (2011-06-24 21:08:53 UTC) #5
Randy Smith (Not in Mondays)
LGTM; you can take the below suggestion or not as you choose. http://codereview.chromium.org/7245013/diff/16001/chrome/browser/download/download_browsertest.cc File chrome/browser/download/download_browsertest.cc ...
9 years, 6 months ago (2011-06-26 21:11:45 UTC) #6
Paweł Hajdan Jr.
Code I commented in the drive-by LGTM.
9 years, 6 months ago (2011-06-27 10:19:15 UTC) #7
achuithb
Thanks for the reviews Randy & Pawel! http://codereview.chromium.org/7245013/diff/16001/chrome/browser/download/download_browsertest.cc File chrome/browser/download/download_browsertest.cc (right): http://codereview.chromium.org/7245013/diff/16001/chrome/browser/download/download_browsertest.cc#newcode778 chrome/browser/download/download_browsertest.cc:778: // is ...
9 years, 6 months ago (2011-06-27 18:34:21 UTC) #8
commit-bot: I haz the power
9 years, 6 months ago (2011-06-27 20:37:52 UTC) #9
Change committed as 90634

Powered by Google App Engine
This is Rietveld 408576698