Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 724453002: Clean up SVGResources (Closed)

Created:
6 years, 1 month ago by rwlbuis
Modified:
6 years ago
Reviewers:
fs
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Clean up SVGResources Clean up SVGResources by: - using nullptr everywhere - replacing unneeded if checks with ASSERTs - making ensureResources return a reference to indicate it always returns an object, not a null pointer Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187327

Patch Set 1 #

Patch Set 2 : Remove another if check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -41 lines) Patch
M Source/core/rendering/svg/SVGResources.cpp View 1 22 chunks +38 lines, -41 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
rwlbuis
PTAL
6 years ago (2014-12-16 15:59:02 UTC) #2
fs
lgtm
6 years ago (2014-12-16 16:37:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/724453002/20001
6 years ago (2014-12-16 16:38:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/42090)
6 years ago (2014-12-16 18:26:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/724453002/20001
6 years ago (2014-12-16 18:43:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/42117)
6 years ago (2014-12-16 21:28:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/724453002/20001
6 years ago (2014-12-16 21:37:19 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/42156)
6 years ago (2014-12-16 23:44:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/724453002/20001
6 years ago (2014-12-17 02:31:52 UTC) #17
commit-bot: I haz the power
6 years ago (2014-12-17 03:36:46 UTC) #18
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187327

Powered by Google App Engine
This is Rietveld 408576698