DevTools: NetworkPanel: tune members visibility.

DevTools: NetworkPanel: tune members visibility.

This is a prereqisite for smooth file split.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185380

[eustas, 2014-11-14 09:43:13]

eustas@chromium.org changed reviewers:
+ vsevik@chromium.org

[apavlov, 2014-11-14 09:55:25]

apavlov@chromium.org changed reviewers:
+ apavlov@chromium.org

[apavlov, 2014-11-14 09:55:26]

https://codereview.chromium.org/724413002/diff/1/Source/devtools/front_end/ne...
File Source/devtools/front_end/network/NetworkPanel.js (right):

https://codereview.chromium.org/724413002/diff/1/Source/devtools/front_end/ne...
Source/devtools/front_end/network/NetworkPanel.js:4: * Copyright (C) 2010, 2011,
2012, 2013, 2014 Google Inc. All rights reserved.
Why this change at all? Only the first year is required (and it has changed for
some reason)

[eustas, 2014-11-14 10:05:17]

https://codereview.chromium.org/724413002/diff/1/Source/devtools/front_end/ne...
File Source/devtools/front_end/network/NetworkPanel.js (right):

https://codereview.chromium.org/724413002/diff/1/Source/devtools/front_end/ne...
Source/devtools/front_end/network/NetworkPanel.js:4: * Copyright (C) 2010, 2011,
2012, 2013, 2014 Google Inc. All rights reserved.
On 2014/11/14 09:55:26, apavlov wrote:
> Why this change at all? Only the first year is required (and it has changed
for
> some reason)

1) Apple lists all years it did modifications to a file
2) There are commits from DevTools members in 2010
3) I'm fine to revert this line =)

[vsevik, 2014-11-14 10:52:59]

https://codereview.chromium.org/724413002/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/network/NetworkPanel.js (right):

https://codereview.chromium.org/724413002/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/network/NetworkPanel.js:172: return
!this._allowPopover;
This is not semantically correct. allowPopover and allowRequestSelection are not
required to be mutually exclusive an dthis could be changed later. Let's keep
both flags.

[eustas, 2014-11-14 12:02:44]

https://codereview.chromium.org/724413002/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/network/NetworkPanel.js (right):

https://codereview.chromium.org/724413002/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/network/NetworkPanel.js:172: return
!this._allowPopover;
On 2014/11/14 10:52:59, vsevik wrote:
> This is not semantically correct. allowPopover and allowRequestSelection are
not
> required to be mutually exclusive an dthis could be changed later. Let's keep
> both flags.

Fixed. Removed allowPopover

[vsevik, 2014-11-14 16:09:33]

The CQ bit was checked by vsevik@chromium.org

[vsevik, 2014-11-14 16:09:35]

lgtm

[commit-bot: I haz the power, 2014-11-14 16:10:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/724413002/40001

[commit-bot: I haz the power, 2014-11-14 17:15:58]

Committed patchset #3 (id:40001) as 185380