chrome/chrome.isolate - Issue 724323002: Non-SFI mode: Enable browser_tests for nacl_helper_nonsfi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome.isolate

Issue 724323002: Non-SFI mode: Enable browser_tests for nacl_helper_nonsfi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome.isolate

diff --git a/chrome/chrome.isolate b/chrome/chrome.isolate

index 8fe855446986fb6dfd824cea41a551109b16252f..28400936a05b931e73ce4aa287483926d0c0d116 100644

--- a/chrome/chrome.isolate

+++ b/chrome/chrome.isolate

@@ -19,6 +19,14 @@

]

}

}],

+ # TODO(hidehiko,mazda): Include nacl_helper_nonsfi for ARM when supported.

+ ['disable_nacl==0 and OS=="linux" and (target_arch=="x64" or target_arch=="ia32")', {

csharp 2014/11/14 14:19:59 Please break into two lines

hidehiko 2014/11/14 18:45:32 Done.

+ 'variables': {

+ 'files': [

+ '<(PRODUCT_DIR)/nacl_helper_nonsfi<(EXECUTABLE_SUFFIX)',

+ ]

+ }

+ }],

['OS=="linux" or OS=="mac" or OS=="win"', {

'variables': {

'files': [

« chrome/browser_tests.isolate ('K') | « chrome/browser_tests.isolate ('k') | chrome/chrome_tests.gypi » ('j') | chrome/test/ppapi/ppapi_test.h » ('J')