Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: chrome/test/ppapi/ppapi_test.h

Issue 724323002: Non-SFI mode: Enable browser_tests for nacl_helper_nonsfi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/ppapi/ppapi_test.h
diff --git a/chrome/test/ppapi/ppapi_test.h b/chrome/test/ppapi/ppapi_test.h
index 8d71b502a8ee0d827abdafcdd08610559f84e464..41ba5bbff1a11eddb191720f91e0c29de23f08f9 100644
--- a/chrome/test/ppapi/ppapi_test.h
+++ b/chrome/test/ppapi/ppapi_test.h
@@ -183,11 +183,29 @@ class PPAPINaClPNaClNonSfiTest : public PPAPINaClTest {
const std::string& test_case) override;
};
+// TODO(hidehiko): Switch for NonSfi tests to use nacl_helper_nonsfi, when
+// it is launched officially. See NaClBrowserTestPnaclTransitionalNonSfi
+// for more details.
+class PPAPINaClPNaClTransitionalNonSfiTest : public PPAPINaClPNaClNonSfiTest {
+ public:
+ virtual void SetUpCommandLine(base::CommandLine* command_line) override;
+};
+
class PPAPIPrivateNaClPNaClNonSfiTest : public PPAPINaClPNaClNonSfiTest {
protected:
virtual void SetUpCommandLine(base::CommandLine* command_line) override;
};
+// TODO(hidehiko): Switch for NonSfi tests to use nacl_helper_nonsfi, when
+// it is launched officially. See NaClBrowserTestPnaclTransitionalNonSfi
+// for more details.
+class PPAPIPrivateNaClPNaClTransitionalNonSfiTest
+ : public PPAPIPrivateNaClPNaClNonSfiTest {
+ protected:
+ virtual void SetUpCommandLine(base::CommandLine* command_line) override;
+};
+
+
class PPAPINaClTestDisallowedSockets : public PPAPITestBase {
public:
virtual void SetUpCommandLine(base::CommandLine* command_line) override;

Powered by Google App Engine
This is Rietveld 408576698