Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: chrome/test/nacl/nacl_browsertest.cc

Issue 724323002: Non-SFI mode: Enable browser_tests for nacl_helper_nonsfi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/nacl/nacl_browsertest.cc
diff --git a/chrome/test/nacl/nacl_browsertest.cc b/chrome/test/nacl/nacl_browsertest.cc
index b8e4af890c7c4cec810b377bf06f5f0b4e17a188..bcf9e2e08a03b1746eb70b2edc418ded49e08fb6 100644
--- a/chrome/test/nacl/nacl_browsertest.cc
+++ b/chrome/test/nacl/nacl_browsertest.cc
@@ -42,10 +42,20 @@ IN_PROC_BROWSER_TEST_F(NaClBrowserTestNonSfiMode, MAYBE_NONSFI(Messaging)) {
RunLoadTest(FILE_PATH_LITERAL("libc_free.html"));
}
+IN_PROC_BROWSER_TEST_F(NaClBrowserTestTransitionalNonSfi,
+ MAYBE_NACL_HELPER_NONSFI(Messaging)) {
+ RunLoadTest(FILE_PATH_LITERAL("libc_free.html"));
+}
+
IN_PROC_BROWSER_TEST_F(NaClBrowserTestNonSfiMode, MAYBE_NONSFI(Irt)) {
RunNaClIntegrationTest(FILE_PATH_LITERAL("irt_test.html"));
}
+IN_PROC_BROWSER_TEST_F(NaClBrowserTestTransitionalNonSfi,
+ MAYBE_NACL_HELPER_NONSFI(Irt)) {
+ RunNaClIntegrationTest(FILE_PATH_LITERAL("irt_test.html"));
+}
+
NACL_BROWSER_TEST_F(NaClBrowserTest, ExitStatus0, {
RunNaClIntegrationTest(FILE_PATH_LITERAL(
"pm_exit_status_test.html?trigger=exit0&expected_exit=0"));
@@ -127,6 +137,10 @@ IN_PROC_BROWSER_TEST_F(NaClBrowserTestPnaclNonSfi,
MAYBE_PNACL_NONSFI(IrtManifestFile)) {
RunNaClIntegrationTest(FILE_PATH_LITERAL("irt_manifest_file_test.html"));
}
+IN_PROC_BROWSER_TEST_F(NaClBrowserTestPnaclTransitionalNonSfi,
+ MAYBE_PNACL_NACL_HELPER_NONSFI(IrtManifestFile)) {
+ RunNaClIntegrationTest(FILE_PATH_LITERAL("irt_manifest_file_test.html"));
+}
#if defined(OS_WIN)
// http://crbug.com/416272
@@ -141,6 +155,10 @@ IN_PROC_BROWSER_TEST_F(NaClBrowserTestPnaclNonSfi,
MAYBE_PNACL_NONSFI(IrtException)) {
RunNaClIntegrationTest(FILE_PATH_LITERAL("irt_exception_test.html"));
}
+IN_PROC_BROWSER_TEST_F(NaClBrowserTestPnaclTransitionalNonSfi,
+ MAYBE_PNACL_NACL_HELPER_NONSFI(IrtException)) {
+ RunNaClIntegrationTest(FILE_PATH_LITERAL("irt_exception_test.html"));
+}
// Some versions of Visual Studio does not like preprocessor
// conditionals inside the argument of a macro, so we put the

Powered by Google App Engine
This is Rietveld 408576698