Non-SFI mode: Enable browser_tests for nacl_helper_nonsfi.

chrome/test/nacl/nacl_browsertest_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_NACL_NACL_BROWSERTEST_UTIL_H_
 #define CHROME_TEST_NACL_NACL_BROWSERTEST_UTIL_H_
 
 #include "base/files/file_path.h"
 #include "base/memory/scoped_ptr.h"
 #include "chrome/test/base/in_process_browser_test.h"
@@ skipping 111 matching lines @@
 
   bool IsAPnaclTest() override;
 };
 
 class NaClBrowserTestPnaclNonSfi : public NaClBrowserTestBase {
  public:
   void SetUpCommandLine(base::CommandLine* command_line) override;
   base::FilePath::StringType Variant() override;
 };
 
+// "Transitional" here means that, this uses nacl_helper_nonsfi which has

[Mark Seaborn, 2014/11/19 06:23:54]

Grammar nit: remove comma after "that"

[hidehiko, 2014/11/19 18:48:51]

Done.

+// nacl_helper feature for Non-SFI mode, but statically linked to newlib
+// instead of using host glibc. It is still under development.
+// TODO(hidehiko): Switch for NonSfi tests to use nacl_helper_nonsfi, when

[Mark Seaborn, 2014/11/19 06:23:54]

Nit: "Switch for" -> "Switch"?  Same below...

[hidehiko, 2014/11/19 18:48:50]

Done.

+// it is launched officially.
+class NaClBrowserTestPnaclTransitionalNonSfi
+    : public NaClBrowserTestPnaclNonSfi {
+ public:
+  void SetUpCommandLine(base::CommandLine* command_line) override;
+};
+
 class NaClBrowserTestNonSfiMode : public NaClBrowserTestBase {
  public:
   void SetUpCommandLine(base::CommandLine* command_line) override;
   base::FilePath::StringType Variant() override;
 };
 
+// TODO(hidehiko): Switch for NonSfi tests to use nacl_helper_nonsfi, when
+// it is launched officially. See NaClBrowserTestPnaclTransitionalNonSfi
+// for more details.
+class NaClBrowserTestTransitionalNonSfi : public NaClBrowserTestNonSfiMode {
+ public:
+  void SetUpCommandLine(base::CommandLine* command_line) override;
+};
+
 // A NaCl browser test only using static files.
 class NaClBrowserTestStatic : public NaClBrowserTestBase {
  public:
   base::FilePath::StringType Variant() override;
   bool GetDocumentRoot(base::FilePath* document_root) override;
 };
 
 // A NaCl browser test that loads from an unpacked chrome extension.
 // The directory of the unpacked extension files is determined by
 // the tester's document root.
@@ skipping 26 matching lines @@
 
 // Sanitizers internally use some syscalls which non-SFI NaCl disallows.
 #if defined(OS_LINUX) && !defined(ADDRESS_SANITIZER) && \
     !defined(THREAD_SANITIZER) && !defined(MEMORY_SANITIZER) && \
     !defined(LEAK_SANITIZER)
 #  define MAYBE_NONSFI(test_case) test_case
 #else
 #  define MAYBE_NONSFI(test_case) DISABLED_##test_case
 #endif
 
+// Currently, we only supports it on x86-32 architecture.

[Mark Seaborn, 2014/11/19 06:23:54]

"only support"

[hidehiko, 2014/11/19 18:48:51]

Done.

+// TODO(hidehiko,mazda): Enable this on ARM, too, when it is supported.
+#if defined(OS_LINUX) && !defined(ADDRESS_SANITIZER) && \
+    !defined(THREAD_SANITIZER) && !defined(MEMORY_SANITIZER) && \
+  !defined(LEAK_SANITIZER) && defined(ARCH_CPU_X86)
+#  define MAYBE_NACL_HELPER_NONSFI(test_case) test_case

[Mark Seaborn, 2014/11/19 06:23:54]

How about naming these #defines as "TRANSITIONAL" rather than "NACL_HELPER" too,
for consistency?

[hidehiko, 2014/11/19 18:48:51]

Done.

+#else
+#  define MAYBE_NACL_HELPER_NONSFI(test_case) DISABLED_##test_case
+#endif
+
 // Currently, translation from pexe to non-sfi nexe is supported only for
 // x86-32 or ARM binary.
 #if defined(OS_LINUX) && (defined(ARCH_CPU_X86) || defined(ARCH_CPU_ARMEL))
 #  define MAYBE_PNACL_NONSFI(test_case) test_case
 #else
 #  define MAYBE_PNACL_NONSFI(test_case) DISABLED_##test_case
 #endif
 
+// Similar to MAYBE_NACL_HELPER_NONSFI, this is not available on ARM yet.
+// TODO(hidehiko,mazda): Merge this to the MAYBE_PNACL_NONSFI when it is
+// supported on ARM.
+#if defined(OS_LINUX) && defined(ARCH_CPU_X86)
+#  define MAYBE_PNACL_NACL_HELPER_NONSFI(test_case) test_case
+#else
+#  define MAYBE_PNACL_NACL_HELPER_NONSFI(test_case) DISABLED_##test_case
+#endif
+
+
 #define NACL_BROWSER_TEST_F(suite, name, body) \
 IN_PROC_BROWSER_TEST_F(suite##Newlib, name) \
 body \
 IN_PROC_BROWSER_TEST_F(suite##GLibc, MAYBE_GLIBC(name)) \
 body \
 IN_PROC_BROWSER_TEST_F(suite##Pnacl, MAYBE_PNACL(name)) \
 body
 
 #endif  // CHROME_TEST_NACL_NACL_BROWSERTEST_UTIL_H_