content/common/input/gesture_event_stream_validator.cc - Issue 724313003: [Android] Always precede Tap gesture events with TapDown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/input/gesture_event_stream_validator.cc

Issue 724313003: [Android] Always precede Tap gesture events with TapDown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/android/content_view_core_impl.cc ('K') | « content/browser/android/content_view_core_impl.cc ('k') | content/common/input/gesture_event_stream_validator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/input/gesture_event_stream_validator.cc

diff --git a/content/common/input/gesture_event_stream_validator.cc b/content/common/input/gesture_event_stream_validator.cc

index b485da4ee1739f58845ce7269acd42c3890c9cbe..09b88c8bb9de18c1cb158b0c762f6ea60902bfde 100644

--- a/content/common/input/gesture_event_stream_validator.cc

+++ b/content/common/input/gesture_event_stream_validator.cc

@@ -72,9 +72,13 @@ bool GestureEventStreamValidator::Validate(const blink::WebGestureEvent& event,

waiting_for_tap_end_ = false;

break;

case WebInputEvent::GestureTap:

+ if (!waiting_for_tap_end_)

+ error_msg->append("Missing TapDown event before Tap\n");

+ waiting_for_tap_end_ = false;

+ break;

case WebInputEvent::GestureDoubleTap:

- // Both Tap and DoubleTap gestures may be synthetically inserted, and do

- // not require a preceding TapDown.

+ // DoubleTap gestures may be synthetically inserted, and do not require a

+ // preceding TapDown.

waiting_for_tap_end_ = false;

break;

default: