Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: content/common/input/gesture_event_stream_validator_unittest.cc

Issue 724313003: [Android] Always precede Tap gesture events with TapDown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/common/input/gesture_event_stream_validator.h" 5 #include "content/common/input/gesture_event_stream_validator.h"
6 6
7 #include "content/common/input/synthetic_web_input_event_builders.h" 7 #include "content/common/input/synthetic_web_input_event_builders.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 using blink::WebInputEvent; 10 using blink::WebInputEvent;
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 EXPECT_TRUE(error_msg.empty()); 174 EXPECT_TRUE(error_msg.empty());
175 175
176 event = Build(WebInputEvent::GestureTapUnconfirmed); 176 event = Build(WebInputEvent::GestureTapUnconfirmed);
177 EXPECT_TRUE(validator.Validate(event, &error_msg)); 177 EXPECT_TRUE(validator.Validate(event, &error_msg));
178 EXPECT_TRUE(error_msg.empty()); 178 EXPECT_TRUE(error_msg.empty());
179 179
180 event = Build(WebInputEvent::GestureTapCancel); 180 event = Build(WebInputEvent::GestureTapCancel);
181 EXPECT_TRUE(validator.Validate(event, &error_msg)); 181 EXPECT_TRUE(validator.Validate(event, &error_msg));
182 EXPECT_TRUE(error_msg.empty()); 182 EXPECT_TRUE(error_msg.empty());
183 183
184 // Tap and DoubleTap do not require a TapDown (unlike TapUnconfirmed and 184 event = Build(WebInputEvent::GestureTapDown);
185 // TapCancel). 185 EXPECT_TRUE(validator.Validate(event, &error_msg));
186 EXPECT_TRUE(error_msg.empty());
187
186 event = Build(WebInputEvent::GestureTap); 188 event = Build(WebInputEvent::GestureTap);
187 EXPECT_TRUE(validator.Validate(event, &error_msg)); 189 EXPECT_TRUE(validator.Validate(event, &error_msg));
188 EXPECT_TRUE(error_msg.empty()); 190 EXPECT_TRUE(error_msg.empty());
189 191
192 // DoubleTap does not require a TapDown (unlike Tap, TapUnconfirmed and
193 // TapCancel).
190 event = Build(WebInputEvent::GestureDoubleTap); 194 event = Build(WebInputEvent::GestureDoubleTap);
191 EXPECT_TRUE(validator.Validate(event, &error_msg)); 195 EXPECT_TRUE(validator.Validate(event, &error_msg));
192 EXPECT_TRUE(error_msg.empty()); 196 EXPECT_TRUE(error_msg.empty());
193 } 197 }
194 198
195 TEST(GestureEventStreamValidator, InvalidTap) { 199 TEST(GestureEventStreamValidator, InvalidTap) {
196 GestureEventStreamValidator validator; 200 GestureEventStreamValidator validator;
197 std::string error_msg; 201 std::string error_msg;
198 WebGestureEvent event; 202 WebGestureEvent event;
199 203
200 // No preceding TapDown. 204 // No preceding TapDown.
201 event = Build(WebInputEvent::GestureTapUnconfirmed); 205 event = Build(WebInputEvent::GestureTapUnconfirmed);
202 EXPECT_FALSE(validator.Validate(event, &error_msg)); 206 EXPECT_FALSE(validator.Validate(event, &error_msg));
203 EXPECT_FALSE(error_msg.empty()); 207 EXPECT_FALSE(error_msg.empty());
204 208
205 event = Build(WebInputEvent::GestureTapCancel); 209 event = Build(WebInputEvent::GestureTapCancel);
206 EXPECT_FALSE(validator.Validate(event, &error_msg)); 210 EXPECT_FALSE(validator.Validate(event, &error_msg));
207 EXPECT_FALSE(error_msg.empty()); 211 EXPECT_FALSE(error_msg.empty());
208 212
213 event = Build(WebInputEvent::GestureTap);
214 EXPECT_FALSE(validator.Validate(event, &error_msg));
215 EXPECT_FALSE(error_msg.empty());
216
209 // TapDown already terminated. 217 // TapDown already terminated.
210 event = Build(WebInputEvent::GestureTapDown); 218 event = Build(WebInputEvent::GestureTapDown);
211 EXPECT_TRUE(validator.Validate(event, &error_msg)); 219 EXPECT_TRUE(validator.Validate(event, &error_msg));
212 EXPECT_TRUE(error_msg.empty()); 220 EXPECT_TRUE(error_msg.empty());
213 221
214 event = Build(WebInputEvent::GestureDoubleTap); 222 event = Build(WebInputEvent::GestureDoubleTap);
215 EXPECT_TRUE(validator.Validate(event, &error_msg)); 223 EXPECT_TRUE(validator.Validate(event, &error_msg));
216 EXPECT_TRUE(error_msg.empty()); 224 EXPECT_TRUE(error_msg.empty());
217 225
218 event = Build(WebInputEvent::GestureTapCancel); 226 event = Build(WebInputEvent::GestureTapCancel);
219 EXPECT_FALSE(validator.Validate(event, &error_msg)); 227 EXPECT_FALSE(validator.Validate(event, &error_msg));
220 EXPECT_FALSE(error_msg.empty()); 228 EXPECT_FALSE(error_msg.empty());
221 229
222 // TapDown already terminated. 230 // TapDown already terminated.
223 event = Build(WebInputEvent::GestureTapDown); 231 event = Build(WebInputEvent::GestureTapDown);
224 EXPECT_TRUE(validator.Validate(event, &error_msg)); 232 EXPECT_TRUE(validator.Validate(event, &error_msg));
225 EXPECT_TRUE(error_msg.empty()); 233 EXPECT_TRUE(error_msg.empty());
226 234
227 event = Build(WebInputEvent::GestureTap); 235 event = Build(WebInputEvent::GestureTap);
228 EXPECT_TRUE(validator.Validate(event, &error_msg)); 236 EXPECT_TRUE(validator.Validate(event, &error_msg));
229 EXPECT_TRUE(error_msg.empty()); 237 EXPECT_TRUE(error_msg.empty());
230 238
231 event = Build(WebInputEvent::GestureTapCancel); 239 event = Build(WebInputEvent::GestureTapCancel);
232 EXPECT_FALSE(validator.Validate(event, &error_msg)); 240 EXPECT_FALSE(validator.Validate(event, &error_msg));
233 EXPECT_FALSE(error_msg.empty()); 241 EXPECT_FALSE(error_msg.empty());
234 } 242 }
235 243
236 } // namespace content 244 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698