Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Unified Diff: tests/barebones/nacl.scons

Issue 7242011: Get rid of assumptions about ".nexe" extension. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: '' Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/barebones/nacl.scons
===================================================================
--- tests/barebones/nacl.scons (revision 5756)
+++ tests/barebones/nacl.scons (working copy)
@@ -58,17 +58,16 @@
if env.IsRunningUnderValgrind(): continue
src = 'barebones_' + basename + '.c'
- nexe = 'barebones_' + basename + '.nexe'
+ nexe_name = 'barebones_' + basename
out = 'barebones_' + basename + '.out'
test = 'run_barebones_' + basename + '_test'
test = 'run_barebones_' + basename + '_test'
- env.ComponentProgram(nexe, [FAKE_STARTUP, src])
+ nexe = env.ComponentProgram(nexe_name, [FAKE_STARTUP, src])
# NOTE: we avoid using zero as the "good" exit status and just
# arbitrarily picked 55. All tests are coded to follow this model.
node = env.CommandSelLdrTestNacl(
- out,
- command=[env.File(nexe)],
+ out, nexe,
exit_status='55',)
env.AddNodeToTestSuite(node,
['small_tests', 'sel_ldr_tests', 'barebones_tests'],
@@ -79,10 +78,10 @@
# a test that the validador can handle an empty segment after the last
Nick Bray 2011/06/23 18:32:24 Spelling
pdox 2011/06/23 20:42:58 Done.
# real segment. The gold linker produces files this
if env.Bit('build_arm') and not env.Bit('bitcode'):
- nexe = '${SCONSTRUCT_DIR}/tests/prebuilt/arm/gold-barebones_hello_world.nexe'
+ nexe = env.File('${SCONSTRUCT_DIR}/tests/prebuilt/arm/gold-barebones_hello_world.nexe')
Nick Bray 2011/06/23 18:32:24 Line length.
pdox 2011/06/23 20:42:58 Done.
node = env.CommandSelLdrTestNacl(
'gold-barebones_hello_world.out',
- command=[env.File(nexe)],
+ nexe,
exit_status='55',)
env.AddNodeToTestSuite(node,
['small_tests', 'sel_ldr_tests'],

Powered by Google App Engine
This is Rietveld 408576698