Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: tests/browser_startup_time/nacl.scons

Issue 7242011: Get rid of assumptions about ".nexe" extension. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: '' Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/browser_dynamic_library/nacl.scons ('k') | tests/bundle_size/nacl.scons » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/browser_startup_time/nacl.scons
===================================================================
--- tests/browser_startup_time/nacl.scons (revision 5777)
+++ tests/browser_startup_time/nacl.scons (working copy)
@@ -11,7 +11,7 @@
# Hope it does not change to do more than just the barebones.
# We must make a separate build though, to get a different nexe "key"
# for the env.Publish() / env.ExtractPublishedFiles() magic.
-nexe = 'browser_startup_time_%s.nexe' % env.get('TARGET_FULLARCH')
+nexe_name = 'browser_startup_time_${TARGET_FULLARCH}'
# Build object file separately to prevent crud left in the source directory.
browser_startup_obj = env.ComponentObject(
@@ -19,7 +19,7 @@
'${SCONSTRUCT_DIR}/tests/ppapi_test_example/ppapi_test_example.cc')
browser_startup_nexe = env.ComponentProgram(
- nexe,
+ nexe_name,
[browser_startup_obj],
EXTRA_LIBS=['${PPAPI_LIBS}',
'ppapi_test_lib',
@@ -31,7 +31,7 @@
# Borrow the smoke tests.
borrowed_files = [env.File('${STAGING_DIR}/ppapi_test_example.js')]
-env.Publish(nexe, 'run',
+env.Publish(nexe_name, 'run',
['browser_startup_time.html',
'browser_startup_time.nmf',
'browser_startup_time.js'])
@@ -46,7 +46,7 @@
node = env.PPAPIBrowserTester(
test_name,
url='browser_startup_time.html',
- files=env.ExtractPublishedFiles(nexe) + borrowed_files,
+ files=env.ExtractPublishedFiles(nexe_name) + borrowed_files,
args=['--enable_experimental_js'],
process_output=output_processor,
# Assume verbosity level of 1 will give us NaClLogs for sel_ldr times.
@@ -67,7 +67,7 @@
# Also check the size of this nexe.
node = env.FileSizeTest('browser_startup_size.out',
- nexe)
+ browser_startup_nexe)
env.AddNodeToTestSuite(node,
test_suites,
'run_browser_startup_size_test')
« no previous file with comments | « tests/browser_dynamic_library/nacl.scons ('k') | tests/bundle_size/nacl.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698