Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1700)

Issue 7242: The Schannel considers some cipher suites (e.g., the... (Closed)

Created:
12 years, 2 months ago by wtc
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

The Schannel considers some cipher suites (e.g., the AES cipher suites) to be TLS only, and won't allow them to be used in SSL 3.0. If an SSL 3.0 server picks such a cipher suite, we need to handle it as if it were TLS intolerant by turning off TLS and retrying. R=darin BUG=3203, 3001 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3295

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -13 lines) Patch
M net/base/net_error_list.h View 1 chunk +4 lines, -0 lines 1 comment Download
M net/base/ssl_client_socket.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 3 chunks +17 lines, -11 lines 0 comments Download
M net/http/http_transaction_winhttp.cc View 1 2 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
wtc
http://codereview.chromium.org/7242/diff/7/215 File net/base/net_error_list.h (right): http://codereview.chromium.org/7242/diff/7/215#newcode85 Line 85: NET_ERROR(SSL_VERSION_OR_CIPHER_MISMATCH, -113) This error code is a mouthful, ...
12 years, 2 months ago (2008-10-10 22:24:38 UTC) #1
darin (slow to review)
12 years, 2 months ago (2008-10-11 07:43:17 UTC) #2
LGTM

Should find a way to write some unit tests for these interesting SSL cases :-)

Powered by Google App Engine
This is Rietveld 408576698