Chromium Code Reviews

Unified Diff: test/mjsunit/mjsunit.js

Issue 724133004: Remove arguments arity check in mjsunit because it vastly slows down the tests. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/mjsunit.js
diff --git a/test/mjsunit/mjsunit.js b/test/mjsunit/mjsunit.js
index 043027908853d0dfd9169553dae00a19a3efde55..00fd03bea2cb5d09295bdab8ae0a9035ce5695fa 100644
--- a/test/mjsunit/mjsunit.js
+++ b/test/mjsunit/mjsunit.js
@@ -239,7 +239,7 @@ var assertUnoptimized;
}
assertSame = function assertSame(expected, found, name_opt) {
- checkArity(arguments, 2, "assertSame");
+// checkArity(arguments, 2, "assertSame");
Michael Starzinger 2014/11/14 10:21:22 So maybe instead of commenting it out, we should r
// TODO(mstarzinger): We should think about using Harmony's egal operator
// or the function equivalent Object.is() here.
@@ -253,7 +253,7 @@ var assertUnoptimized;
assertEquals = function assertEquals(expected, found, name_opt) {
- checkArity(arguments, 2, "assertEquals");
+// checkArity(arguments, 2, "assertEquals");
if (!deepEquals(found, expected)) {
fail(PrettyPrint(expected), found, name_opt);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine