Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 724083003: Revert of Soft fail for invalid cache data. (Closed)

Created:
6 years, 1 month ago by vogelheim
Modified:
6 years, 1 month ago
Reviewers:
vogelheim1, Yang
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Revert of Soft fail for invalid cache data. (patchset #2 id:20001 of https://codereview.chromium.org/724023002/) Reason for revert: Build bots break due to memory leak. Original issue's description: > Soft fail for invalid cache data. > > API=ScriptCompiler::CachedData::rejected > LOG=Y > R=vogelheim@google.com, vogelheim@chromium.org > > Committed: https://chromium.googlesource.com/v8/v8/+/eafce666f49f13011849b6c0c40b271676ec91cf TBR=vogelheim@google.com,yangguo@chromium.org NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -106 lines) Patch
M include/v8.h View 2 chunks +1 line, -6 lines 0 comments Download
M src/api.cc View 2 chunks +1 line, -6 lines 0 comments Download
M src/compiler.h View 2 chunks +1 line, -5 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/parser.h View 3 chunks +4 lines, -17 lines 0 comments Download
M src/parser.cc View 8 chunks +13 lines, -10 lines 0 comments Download
M src/serialize.h View 3 chunks +4 lines, -11 lines 0 comments Download
M src/serialize.cc View 5 chunks +14 lines, -15 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M test/cctest/test-parsing.cc View 3 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
vogelheim
Created Revert of Soft fail for invalid cache data.
6 years, 1 month ago (2014-11-13 16:35:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/724083003/1
6 years, 1 month ago (2014-11-13 16:36:34 UTC) #2
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 16:36:36 UTC) #4
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698