Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 724083002: Oilpan: fix build after r185293. (Closed)

Created:
6 years, 1 month ago by sof
Modified:
6 years, 1 month ago
Reviewers:
haraken, oilpan-reviews
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build after r185293. R=haraken BUG=430337 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185302

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/modules/beacon/NavigatorBeacon.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
sof
Please take a look.
6 years, 1 month ago (2014-11-13 16:06:50 UTC) #1
haraken
LGTM
6 years, 1 month ago (2014-11-13 16:08:31 UTC) #2
sof
It would be preferable if the generated getter for [GarbageCollected] union members returned a T* ...
6 years, 1 month ago (2014-11-13 16:09:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/724083002/1
6 years, 1 month ago (2014-11-13 16:16:12 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 16:17:42 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 185302

Powered by Google App Engine
This is Rietveld 408576698