Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: test/cctest/test-api.cc

Issue 724053004: Revert "Soft fail for invalid cache data." (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/serialize.cc ('k') | test/cctest/test-parsing.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index 8ef6a4444f1b9cc225638d0995cc1f4d494129fb..98c17dea2d860948cc6c5b7b8c7842fe12640f78 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -24207,28 +24207,3 @@ TEST(StreamingUtf8ScriptWithMultipleMultibyteCharactersSomeSplit2) {
const char* chunks[] = {chunk1, chunk2, "foo();", NULL};
RunStreamingTest(chunks, v8::ScriptCompiler::StreamedSource::UTF8);
}
-
-
-void TestInvalidCacheData(v8::ScriptCompiler::CompileOptions option) {
- const char* garbage = "garbage garbage garbage garbage.";
- const uint8_t* data = reinterpret_cast<const uint8_t*>(garbage);
- int length = 16;
- v8::ScriptCompiler::CachedData* cached_data =
- new v8::ScriptCompiler::CachedData(data, length);
- DCHECK(!cached_data->rejected);
- v8::ScriptOrigin origin(v8_str("origin"));
- v8::ScriptCompiler::Source source(v8_str("42"), origin, cached_data);
- v8::Handle<v8::Script> script =
- v8::ScriptCompiler::Compile(CcTest::isolate(), &source, option);
- CHECK(cached_data->rejected);
- CHECK_EQ(42, script->Run()->Int32Value());
-}
-
-
-TEST(InvalidCacheData) {
- v8::V8::Initialize();
- v8::HandleScope scope(CcTest::isolate());
- LocalContext context;
- TestInvalidCacheData(v8::ScriptCompiler::kConsumeParserCache);
- TestInvalidCacheData(v8::ScriptCompiler::kConsumeCodeCache);
-}
« no previous file with comments | « src/serialize.cc ('k') | test/cctest/test-parsing.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698