Issue 724053004: Revert "Soft fail for invalid cache data."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 724053004: Revert "Soft fail for invalid cache data." (Closed)

Created:
6 years, 1 month ago by vogelheim

Modified:
6 years, 1 month ago

Reviewers:
Yang

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

Revert "Soft fail for invalid cache data." This reverts commit eafce666f49f13011849b6c0c40b271676ec91cf. Original commit failed some tests w/ memory leaks. TBR=yangguo@chromium.org BUG= Committed: https://chromium.googlesource.com/v8/v8/+/f83f10973e3e43faf2734832d5e862aa431bfa68

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -105 lines)			Patch
M	include/v8.h	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	src/api.cc	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	src/compiler.h	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	src/compiler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/parser.h	View	3 chunks	+3 lines, -16 lines	0 comments	Download
M	src/parser.cc	View	8 chunks	+13 lines, -10 lines	0 comments	Download
M	src/serialize.h	View	3 chunks	+4 lines, -11 lines	0 comments	Download
M	src/serialize.cc	View	5 chunks	+14 lines, -15 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+0 lines, -25 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View	3 chunks	+7 lines, -9 lines	0 comments	Download
M	test/cctest/test-serialize.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 1 (0 generated)

vogelheim

6 years, 1 month ago (2014-11-13 16:47:14 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f83f10973e3e43faf2734832d5e862aa431bfa68 (tree was closed).