Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 724053003: DevTools: Add a test for disabling breakpoints. (Closed)

Created:
6 years, 1 month ago by vsevik
Modified:
6 years, 1 month ago
Reviewers:
sergeyv, yurys, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Add a test for disabling breakpoints. The test is added disabled since this functionality is currently broken BUG=432493 R=pfeldman, yurys, sergeyv Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185304

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -0 lines) Patch
A LayoutTests/inspector/sources/debugger/disable-breakpoints.html_disabled View 1 chunk +113 lines, -0 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/disable-breakpoints-expected.txt View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
vsevik
PTAL
6 years, 1 month ago (2014-11-13 15:21:22 UTC) #1
yurys
lgtm You may also mark it as skipped instead of renaming.
6 years, 1 month ago (2014-11-13 15:23:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/724053003/1
6 years, 1 month ago (2014-11-13 15:25:59 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 16:29:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185304

Powered by Google App Engine
This is Rietveld 408576698