Issue 724053002: Revert "[turbofan] Smartify the GraphReducer."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 724053002: Revert "[turbofan] Smartify the GraphReducer." (Closed)

Created:
6 years, 1 month ago by Michael Starzinger

Modified:
6 years, 1 month ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

Revert "[turbofan] Smartify the GraphReducer." This reverts commit f04750737063 due to mjsunit/numops-fuzz-part2 hitting an assertion in the ARM assembler. TBR=bmeurer@chromium.org TEST=mjsunit/numops-fuzz-part2 Committed: https://chromium.googlesource.com/v8/v8/+/78332973e2995f0162107b9afe3cb2430ad17ab5

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -227 lines)			Patch
M	src/compiler/graph-reducer.h	View	1 chunk	+3 lines, -22 lines	0 comments	Download
M	src/compiler/graph-reducer.cc	View	1 chunk	+46 lines, -156 lines	0 comments	Download
M	src/compiler/pipeline.cc	View	5 chunks	+4 lines, -8 lines	0 comments	Download
M	src/zone-containers.h	View	2 chunks	+4 lines, -21 lines	0 comments	Download
M	test/cctest/compiler/test-changes-lowering.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/compiler/test-graph-reducer.cc	View	14 chunks	+14 lines, -14 lines	0 comments	Download
M	test/cctest/compiler/test-simplified-lowering.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/unittests/compiler/graph-reducer-unittest.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Michael Starzinger

6 years, 1 month ago (2014-11-13 14:07:09 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
78332973e2995f0162107b9afe3cb2430ad17ab5 (tree was closed).