Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1613)

Unified Diff: sync/engine/sync_scheduler_impl.cc

Issue 72403003: sync: Per-type update application (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/engine/sync_scheduler_impl.cc
diff --git a/sync/engine/sync_scheduler_impl.cc b/sync/engine/sync_scheduler_impl.cc
index 3cb5619a93411bef449e6190e806b80daa4ee24a..b7d405c705a0e29e90ec99b75892b32a9b1bb68e 100644
--- a/sync/engine/sync_scheduler_impl.cc
+++ b/sync/engine/sync_scheduler_impl.cc
@@ -239,10 +239,8 @@ void SyncSchedulerImpl::Start(Mode mode) {
}
ModelTypeSet SyncSchedulerImpl::GetEnabledAndUnthrottledTypes() {
- ModelTypeSet enabled_types =
- GetRoutingInfoTypes(session_context_->routing_info());
- ModelTypeSet throttled_types =
- nudge_tracker_.GetThrottledTypes();
+ ModelTypeSet enabled_types = session_context_->enabled_types();
+ ModelTypeSet throttled_types = nudge_tracker_.GetThrottledTypes();
return Difference(enabled_types, throttled_types);
}
@@ -344,8 +342,7 @@ bool SyncSchedulerImpl::CanRunNudgeJobNow(JobPriority priority) {
return false;
}
- const ModelTypeSet enabled_types =
- GetRoutingInfoTypes(session_context_->routing_info());
+ const ModelTypeSet enabled_types = session_context_->enabled_types();
if (nudge_tracker_.GetThrottledTypes().HasAll(enabled_types)) {
SDVLOG(1) << "Not running a nudge because we're fully type throttled.";
return false;
@@ -467,8 +464,8 @@ void SyncSchedulerImpl::DoNudgeSyncSessionJob(JobPriority priority) {
DCHECK(CalledOnValidThread());
DCHECK(CanRunNudgeJobNow(priority));
- DVLOG(2) << "Will run normal mode sync cycle with routing info "
- << ModelSafeRoutingInfoToString(session_context_->routing_info());
+ DVLOG(2) << "Will run normal mode sync cycle with types "
+ << ModelTypeSetToString(session_context_->enabled_types());
scoped_ptr<SyncSession> session(SyncSession::Build(session_context_, this));
bool premature_exit = !syncer_->NormalSyncShare(
GetEnabledAndUnthrottledTypes(),
@@ -506,11 +503,11 @@ bool SyncSchedulerImpl::DoConfigurationSyncSessionJob(JobPriority priority) {
return false;
}
- SDVLOG(2) << "Will run configure SyncShare with routes "
- << ModelSafeRoutingInfoToString(session_context_->routing_info());
+ SDVLOG(2) << "Will run configure SyncShare with types "
+ << ModelTypeSetToString(session_context_->enabled_types());
scoped_ptr<SyncSession> session(SyncSession::Build(session_context_, this));
bool premature_exit = !syncer_->ConfigureSyncShare(
- GetRoutingInfoTypes(session_context_->routing_info()),
+ session_context_->enabled_types(),
pending_configure_params_->source,
session.get());
AdjustPolling(FORCE_RESET);
@@ -566,8 +563,8 @@ void SyncSchedulerImpl::DoPollSyncSessionJob() {
return;
}
- SDVLOG(2) << "Polling with routes "
- << ModelSafeRoutingInfoToString(session_context_->routing_info());
+ SDVLOG(2) << "Polling with types "
+ << ModelTypeSetToString(session_context_->enabled_types());
scoped_ptr<SyncSession> session(SyncSession::Build(session_context_, this));
syncer_->PollSyncShare(
GetEnabledAndUnthrottledTypes(),

Powered by Google App Engine
This is Rietveld 408576698