Soft fail for invalid cache data.

src/api.cc

Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index c7ebc7714f57a052f99964e44e412a2d66770c7d..cb879f41dd38e52476a298ed5daf554ab2f8523d 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -1536,7 +1536,10 @@ void ObjectTemplate::SetInternalFieldCount(int value) {
 
 ScriptCompiler::CachedData::CachedData(const uint8_t* data_, int length_,
                                        BufferPolicy buffer_policy_)
-    : data(data_), length(length_), buffer_policy(buffer_policy_) {}
+    : data(data_),
+      length(length_),
+      rejected(false),
+      buffer_policy(buffer_policy_) {}
 
 
 ScriptCompiler::CachedData::~CachedData() {
@@ -1752,6 +1755,8 @@ Local<UnboundScript> ScriptCompiler::CompileUnbound(
       source->cached_data = new CachedData(
           script_data->data(), script_data->length(), CachedData::BufferOwned);
       script_data->ReleaseDataOwnership();
+    } else if (options == kConsumeParserCache || options == kConsumeCodeCache) {
+      source->cached_data->rejected = (script_data == NULL);

[vogelheim, 2014/11/13 13:01:15]

I find this a bit weird...

- I expected ..->rejected to be set at the location where the cached_data was
actually rejected.
- Instead, that code deletes the reference to cached_data, but not the
cached_data object.
- Presence of cached_data is then treated as an error code of sorts.
  - This would also trigger if has_pending_execution.
    (See comment above.)

I'm uneasy about this, but, honestly, given the current code structure I don't
see a super elegant way around this, so I'm a bit unsure on what to advise...

[vogelheim, 2014/11/13 13:03:00]

If ScriptData is the "internal" structure (vs CachedData as an "API" structure)
we use to pass around all pertinent information, then maybe ScriptData should
have a rejected flag, too, or maybe just a bool* reference to CachedData's
rejected instance?

     }
     delete script_data;

[vogelheim, 2014/11/13 13:01:15]

If script_data was nullified along the way, this is a noop. Who deletes it then?

   }