Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 723963003: [ServiceWorker] Set FetchEvent's request's headers' guard to immutable (Closed)

Created:
6 years, 1 month ago by horo
Modified:
6 years, 1 month ago
Reviewers:
haraken, nhiroki
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Set FetchEvent's request's headers' guard to immutable The spec of ServiceWorker was changed. https://github.com/slightlyoff/ServiceWorker/issues/559 https://github.com/slightlyoff/ServiceWorker/commit/fe2cd64e9d84c316fc02b7c29648b0c712402746 BUG=N/A TEST=http/tests/serviceworker/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185416

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M LayoutTests/http/tests/serviceworker/request-end-to-end.html View 1 2 chunks +5 lines, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/request-end-to-end-worker.js View 1 1 chunk +8 lines, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
horo
nhiroki@ Could you please review?
6 years, 1 month ago (2014-11-13 08:46:58 UTC) #3
nhiroki
LGTM fyi: The spec was slightly changed (*) after you published this issue, it seems ...
6 years, 1 month ago (2014-11-17 03:30:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723963003/20001
6 years, 1 month ago (2014-11-17 03:46:39 UTC) #6
commit-bot: I haz the power
Failed to apply patch for LayoutTests/http/tests/serviceworker/request-end-to-end.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 1 month ago (2014-11-17 03:46:47 UTC) #8
horo
haraken@ Could you please review Source/web/ServiceWorkerGlobalScopeProxy.cpp? Thank you.
6 years, 1 month ago (2014-11-17 03:55:42 UTC) #10
haraken
LGTM for web/.
6 years, 1 month ago (2014-11-17 03:56:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723963003/40001
6 years, 1 month ago (2014-11-17 04:02:41 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 04:57:39 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as 185416

Powered by Google App Engine
This is Rietveld 408576698