Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 723943002: Remove EncodingAPI runtime flag(status=stable) (Closed)

Created:
6 years, 1 month ago by anujsharma
Modified:
6 years, 1 month ago
Reviewers:
Mike West, *jsbell
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove EncodingAPI runtime flag(status=stable) BUG=402536 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185336

Patch Set 1 #

Patch Set 2 : Adding one more dependent file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M Source/modules/encoding/TextDecoder.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/encoding/TextEncoder.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
anujsharma
PTAL
6 years, 1 month ago (2014-11-13 08:51:46 UTC) #2
Mike West
The removal seems fine. I'll LGTM it to give you OWNERS approval. Please get jsbell@ ...
6 years, 1 month ago (2014-11-13 09:03:03 UTC) #5
anujsharma
On 2014/11/13 09:03:03, Mike West wrote: > The removal seems fine. I'll LGTM it to ...
6 years, 1 month ago (2014-11-13 09:08:18 UTC) #6
jsbell
lgtm
6 years, 1 month ago (2014-11-13 18:05:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723943002/20001
6 years, 1 month ago (2014-11-13 18:05:43 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/36377)
6 years, 1 month ago (2014-11-13 20:28:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723943002/20001
6 years, 1 month ago (2014-11-13 20:47:08 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/36406)
6 years, 1 month ago (2014-11-13 22:59:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723943002/20001
6 years, 1 month ago (2014-11-13 23:01:26 UTC) #17
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 00:53:08 UTC) #18
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 185336

Powered by Google App Engine
This is Rietveld 408576698