public/platform/WebServiceWorkerProviderClient.h - Issue 723923002: ServiceWorker: Add support for .skipWaiting and controllerchange event(1/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/WebServiceWorkerProviderClient.h

Issue 723923002: ServiceWorker: Add support for .skipWaiting and controllerchange event(1/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: webcallback->skipwaitingcallbacks, test re-write Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/serviceworker/skip-waiting.html ('K') | « Source/web/ServiceWorkerGlobalScopeClientImpl.cpp ('k') | public/platform/WebServiceWorkerSkipWaitingCallbacks.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: public/platform/WebServiceWorkerProviderClient.h

diff --git a/public/platform/WebServiceWorkerProviderClient.h b/public/platform/WebServiceWorkerProviderClient.h

index 0214b9d594715e4f5bb6e80e7b8a6577732b264e..9820e96c86b55a14562216f5844fbaed6fa4b633 100644

--- a/public/platform/WebServiceWorkerProviderClient.h

+++ b/public/platform/WebServiceWorkerProviderClient.h

@@ -45,7 +45,7 @@ class WebServiceWorkerProviderClient {

public:

virtual ~WebServiceWorkerProviderClient() { }

- virtual void setController(WebServiceWorker*) = 0;

+ virtual void setController(WebServiceWorker*, bool shouldNotifyControllerChange) = 0;

virtual void setReadyRegistration(WebServiceWorkerRegistration*) = 0;

virtual void dispatchMessageEvent(const WebString& message, const WebMessagePortChannelArray&) = 0;