Source/web/ServiceWorkerGlobalScopeClientImpl.h - Issue 723923002: ServiceWorker: Add support for .skipWaiting and controllerchange event(1/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ServiceWorkerGlobalScopeClientImpl.h

Issue 723923002: ServiceWorker: Add support for .skipWaiting and controllerchange event(1/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: webcallback->skipwaitingcallbacks, test re-write Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/serviceworker/skip-waiting.html ('K') | « Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h ('k') | Source/web/ServiceWorkerGlobalScopeClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/ServiceWorkerGlobalScopeClientImpl.h

diff --git a/Source/web/ServiceWorkerGlobalScopeClientImpl.h b/Source/web/ServiceWorkerGlobalScopeClientImpl.h

index a38b0eaa4239088f90b42e7e4c05ba8d6ccd76db..fe63109b06a57701b23a7882fa3fe87751760bf9 100644

--- a/Source/web/ServiceWorkerGlobalScopeClientImpl.h

+++ b/Source/web/ServiceWorkerGlobalScopeClientImpl.h

@@ -33,6 +33,7 @@

#include "modules/serviceworkers/ServiceWorkerGlobalScopeClient.h"

#include "public/platform/WebServiceWorkerClientsInfo.h"

+#include "public/platform/WebServiceWorkerSkipWaitingCallbacks.h"

#include "wtf/OwnPtr.h"

namespace blink {

@@ -60,6 +61,7 @@ public:

virtual void didHandlePushEvent(int pushEventID, WebServiceWorkerEventResult) override;

virtual void didHandleSyncEvent(int syncEventID) override;

virtual void postMessageToClient(int clientID, const WebString& message, PassOwnPtr<WebMessagePortChannelArray>) override;

+ virtual void skipWaiting(WebServiceWorkerSkipWaitingCallbacks*) override;

virtual void trace(Visitor* visitor) override { ServiceWorkerGlobalScopeClient::trace(visitor); }