ServiceWorker: Add support for .skipWaiting and controllerchange event(1/3)

LayoutTests/http/tests/serviceworker/resources/skip-waiting.js

+function onMessageDefault(e) {

[jsbell, 2014/11/13 23:07:50]

Please rename file to skip-waiting-worker.js, to match other worker scripts.

[xiang, 2014/11/28 08:00:47]

Done.

+  var message = e.data;
+  if ('port' in message) {
+    if (self.done)

[jsbell, 2014/11/13 23:07:50]

The way this worker is designed, if anything fails (e.g. a promise rejects
instead of resolves, or something starts throwing e.g. method is removed leading
to an exception) then the test will unhelpfully timeout instead of failing with
an error.

Can you add .catch clauses to the promise chains that (with some changes here)
make the message handler send back 'fail' ?

[xiang, 2014/11/28 08:00:47]

Done.

+      message.port.postMessage('done');
+  }
+}
+
+function testSkipWaiting() {
+  onmessage = onMessageDefault;
+
+  skipWaiting()

[jsbell, 2014/11/13 23:07:50]

Just as a style thing, we tend to use self.onmessage, self.skipWaiting() and so
on when referring to properties on the worker's global object, rather than
defined in the script.

(The functionality is identical, of course, it's just more readable for those
unfamiliar with what's on the global.)

[xiang, 2014/11/28 08:00:47]

Done.

+    .then(function(result) {
+       if (result === undefined)

[jsbell, 2014/11/13 23:07:50]

otherwise, throw so the promise rejects? (see comment above)

[xiang, 2014/11/28 08:00:47]

Done.

+         self.done = true;
+    });
+}
+
+function testMultipleSkipWaiting() {
+  onmessage = onMessageDefault;
+
+  var promises = [];
+  for (var i = 0; i < 8; ++i) {
+    promises.push(skipWaiting());
+  }
+  Promise.all(promises)
+    .then(function(results) {
+        self.done = true;
+    });
+}
+
+function testSkipWaitingAfterInstalled() {
+  var sate = 'starting';

[jsbell, 2014/11/13 23:07:50]

This line doesn't look like it does anything? lines below assume state is a
global.

[xiang, 2014/11/28 08:00:47]

Done.

+
+  onmessage = function(e) {
+    var message = e.data;
+    if ('port' in message) {
+      var messagePort = message.port;
+      if (self.state !== 'installing') {
+        messagePort.postMessage(state);
+        return;
+      }
+      skipWaiting()
+        .then(function() {
+           messagePort.postMessage(state);
+        });
+    }
+  };
+
+  oninstall = function() {
+    state = 'installing';

[jsbell, 2014/11/13 23:07:50]

Be consistent with tests above (i.e. use self.state)

[xiang, 2014/11/28 08:00:47]

Done.

+  };
+
+  onactivate = function() {
+    state = 'activating';
+  };
+}
+
+if (scope.match('blank')) {

[jsbell, 2014/11/13 23:07:50]

Use /blank/ to make it clear the match is being done against a regexp.

+  testSkipWaitingAfterInstalled();
+} else if (scope.match('multiple-skip-waiting')) {

[jsbell, 2014/11/13 23:07:50]

Use /multiple-skip-waiting/

[xiang, 2014/11/28 08:00:47]

don't need them anymore.

+  testMultipleSkipWaiting();
+} else {
+  testSkipWaiting();
+}