Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 723863002: Re-enable the editing tests (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
rafaelw
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Re-enable the editing tests Now that we have event sender, we can test editing again. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6ab456db145520de711e5e03b0e5c55a32f3c385

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -62 lines) Patch
M sky/tests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/tests/editing/backspace.sky View 1 chunk +9 lines, -12 lines 0 comments Download
M sky/tests/editing/backspace-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M sky/tests/editing/replace.sky View 1 chunk +15 lines, -18 lines 0 comments Download
M sky/tests/editing/replace-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M sky/tests/editing/selection.sky View 1 chunk +15 lines, -18 lines 0 comments Download
M sky/tests/editing/selection-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M sky/tests/editing/typing.sky View 1 chunk +8 lines, -11 lines 0 comments Download
M sky/tests/editing/typing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
A sky/tests/resources/event-sender.sky View 1 chunk +77 lines, -0 lines 7 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
6 years, 1 month ago (2014-11-13 00:51:37 UTC) #1
rafaelw
lgtm w/ nits https://codereview.chromium.org/723863002/diff/1/sky/tests/resources/event-sender.sky File sky/tests/resources/event-sender.sky (right): https://codereview.chromium.org/723863002/diff/1/sky/tests/resources/event-sender.sky#newcode9 sky/tests/resources/event-sender.sky:9: var g_done = false; no need ...
6 years, 1 month ago (2014-11-13 00:57:25 UTC) #2
abarth-chromium
https://codereview.chromium.org/723863002/diff/1/sky/tests/resources/event-sender.sky File sky/tests/resources/event-sender.sky (right): https://codereview.chromium.org/723863002/diff/1/sky/tests/resources/event-sender.sky#newcode9 sky/tests/resources/event-sender.sky:9: var g_done = false; On 2014/11/13 at 00:57:25, rafaelw ...
6 years, 1 month ago (2014-11-13 01:00:50 UTC) #3
abarth-chromium
6 years, 1 month ago (2014-11-13 01:01:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6ab456db145520de711e5e03b0e5c55a32f3c385 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698