Issue 723853003: Rewrite MachMessageServer::Run()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 723853003: Rewrite MachMessageServer::Run() (Closed)

Created:
6 years ago by Mark Mentovai

Modified:
6 years ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@mach_message_deadline

Project:
crashpad

Visibility:
Public.

Rewrite MachMessageServer::Run(). This method is now much more straightforward, easy to understand, and maintainable. There are no externally-visible changes. TEST=util_test MachMessageServer.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/ef0b7cf6d59c5708b6167a42c2b2b024f6b5205a

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+159 lines, -187 lines)			Patch
	M	util/mach/mach_message_server.cc	View		4 chunks	+159 lines, -187 lines	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

This is the final change in a series that improves the design of MachMessageServer. The ...

6 years ago (2014-12-02 22:00:39 UTC) #2

Mark Mentovai

6 years ago (2014-12-03 21:45:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ef0b7cf6d59c5708b6167a42c2b2b024f6b5205a (presubmit successful).