Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 72383005: Emulator script improvements: config templates, --api-level, and mips support. (Closed)

Created:
7 years, 1 month ago by Andrew Hayden (chromium.org)
Modified:
7 years, 1 month ago
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Emulator script improvements: config templates, --api-level, and mips support. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236219

Patch Set 1 #

Patch Set 2 : presubmit checks, and delete unused API_TARGET variable #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -79 lines) Patch
M build/android/avd.py View 1 3 chunks +13 lines, -2 lines 0 comments Download
D build/android/avd_configs/AVD_for_Galaxy_Nexus_by_Google_arm.avd/config.ini View 1 chunk +0 lines, -30 lines 0 comments Download
D build/android/avd_configs/AVD_for_Galaxy_Nexus_by_Google_x86.avd/config.ini View 1 chunk +0 lines, -29 lines 0 comments Download
M build/android/pylib/utils/emulator.py View 1 8 chunks +74 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Andrew Hayden (chromium.org)
Building on https://codereview.chromium.org/59943011/ this patch allows the avd.py script to launch emulators targeting any API ...
7 years, 1 month ago (2013-11-18 16:36:09 UTC) #1
Maria
lgtm That looks great.
7 years, 1 month ago (2013-11-18 22:08:50 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 1 month ago (2013-11-19 17:10:47 UTC) #3
navabi
On 2013/11/19 17:10:47, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
7 years, 1 month ago (2013-11-19 19:12:10 UTC) #4
navabi1
On 2013/11/19 19:12:10, navabi wrote: > On 2013/11/19 17:10:47, I haz the power (commit-bot) wrote: ...
7 years, 1 month ago (2013-11-19 19:12:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/72383005/70001
7 years, 1 month ago (2013-11-19 22:25:40 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=37064
7 years, 1 month ago (2013-11-20 02:02:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/72383005/70001
7 years, 1 month ago (2013-11-20 07:47:59 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-20 10:39:50 UTC) #9
Message was sent while issue was closed.
Change committed as 236219

Powered by Google App Engine
This is Rietveld 408576698